From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46FCEC072A4 for ; Mon, 20 May 2019 17:29:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 292F8214DA for ; Mon, 20 May 2019 17:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390600AbfETR3Q (ORCPT ); Mon, 20 May 2019 13:29:16 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:58481 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392932AbfETR2u (ORCPT ); Mon, 20 May 2019 13:28:50 -0400 Received: from [2a01:598:8989:90c3:fc90:b8ff:fed0:1fb6] (helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hSm5f-0006Sl-Iv; Mon, 20 May 2019 19:28:47 +0200 Date: Mon, 20 May 2019 19:28:35 +0200 (CEST) From: Thomas Gleixner To: Richard Fontana cc: Philippe Ombredanne , linux-spdx@vger.kernel.org, Steve Winslow Subject: Re: [patch 16/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 16 In-Reply-To: Message-ID: References: <20190519135130.462579320@linutronix.de> <20190519154042.138630237@linutronix.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org Richard, On Mon, 20 May 2019, Richard Fontana wrote: > First, from an SPDX conformance perspective (I assume this whole > exercise aims to be SPDX conformant, although I'm not really clear on Yes, the aim is to have a SPDX clean source tree, which has removed all the randomly chosen boilerplate/references etc. The review process here is conducted to actually spot the cases where the machine decided (on whatever base) something which is not 100% clear. We sort out these cases and we need to do further investigation, talk to copyright holders or eventually come up with some extra SPDX tag which expresses the magic extra bits, in this case the disclaimer. > GPLv3 says: "for material you add to a covered work, you may (if > authorized by the copyright holders of that material) supplement the > terms of this License with terms: > a) Disclaiming warranty or limiting liability differently from the > terms of sections 15 and 16 of this License;" , which is treated as an > allowable additional restriction. And this codified an occasional > practice under GPLv2 which I believe the FSF had authorized. So if one > copyright holder decided to tack on the BSD disclaimer language to an > otherwise standard GPLv2 notice, that presumably should be treated > like an additional restriction, which needs to be left in place, and > perhaps even the appropriate thing is to define an SPDX identifier to > account for the additional language. (Given the way "exception" is > sort of defined at https://spdx.org/licenses/exceptions-index.html it > might not be appropriate to use the "WITH" syntax.) Right. I'm not a SPDX wizard, but I think we need a new SPDX id, e.g. BSD-DISCLAIMER or something to that effect and then have SPDX-License-Identifier: GPL-2.0-or-later AND BSD-DISCLAIMER as the concluded license, which allows us to remove both the GPL boilerplate and the disclaimer. Right now we can't do anything because the BSD-DISCLAIMER id does not exist. As you explained above something like this is needed anyway as it's going to happen with GPLv3 as well and it seems it's sufficiently wide spread even in the kernel code. Thanks, tglx