From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA50C04AAC for ; Mon, 20 May 2019 17:48:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 019D2206B6 for ; Mon, 20 May 2019 17:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725810AbfETRsC (ORCPT ); Mon, 20 May 2019 13:48:02 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:58652 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbfETRsC (ORCPT ); Mon, 20 May 2019 13:48:02 -0400 Received: from [2a01:598:8989:90c3:fc90:b8ff:fed0:1fb6] (helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hSmOC-0006qt-UL; Mon, 20 May 2019 19:47:57 +0200 Date: Mon, 20 May 2019 19:47:51 +0200 (CEST) From: Thomas Gleixner To: J Lovejoy cc: Allison Randal , linux-spdx@vger.kernel.org Subject: Re: [patch 02/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 2 In-Reply-To: Message-ID: References: <20190519135130.462579320@linutronix.de> <20190519154040.743319710@linutronix.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-783036227-1558374476=:1635" X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-783036227-1558374476=:1635 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Mon, 20 May 2019, J Lovejoy wrote: > > On May 19, 2019, at 10:00 PM, Thomas Gleixner wrote: > > > > > > On Sun, 19 May 2019, Allison Randal wrote: > > > >> Since the text says "gnu *library* general public license", shouldn't > >> the SPDX license identifier be LGPL instead of GPL? > > > > Well spotted > > indeed. is anyone else concerned that the scanner(s) didn’t catch this? > This is the kind of thing that (I think) would have been > caught. Considering that we have to rely on the tooling to a certain > degree (i.e. we can’t possibly look at every file individually), this has > me a bit worried… The problem with the tools is that they need tons of heuristics to cope with the endless amount of mess. So it's a given that some of the heuristics are wrong. I spent quite some time to think about a solution to this and the way I proposed doing it, e.g. reduce the mess to normalized patterns, allows us to avoid staring at 20k patch snippets. We really need to spot the failures in the patterns, not the actual file level patches. The patcher itself is going to remove the file level equivalent of the normalized pattern and add the concluded SPDX identifier instead. Not more, not less. If the tools would be perfect we would not need to look at any of these things ... Thanks, tglx --8323329-783036227-1558374476=:1635--