From: Thomas Gleixner <tglx@linutronix.de>
To: Joe Perches <joe@perches.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Greg KH <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-spdx@vger.kernel.org
Subject: Re: [GIT PULL] SPDX update for 5.2-rc1 - round 1
Date: Wed, 22 May 2019 12:14:09 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1905221210340.1637@nanos.tec.linutronix.de> (raw)
In-Reply-To: <eae2d0e80824cc84965c571a0ea097e14d3f498c.camel@perches.com>
On Tue, 21 May 2019, Joe Perches wrote:
> On Wed, 2019-05-22 at 13:32 +0900, Masahiro Yamada wrote:
> > (Perhaps, checkpatch.pl can suggest newer tags in case
> > patch submitters do not even know that deprecation.)
>
> I'd still prefer the kernel use of a single SPDX style.
>
> I don't know why the -only and -or-later forms were
> used for this patch, but I like it.
Mostly because the underlying tools use the latest SDPX version.
> Is it agreed that the GPL-<v>-only and GPL-<v>-or-later
> forms should be preferred for new SPDX identifiers?
I have no strong opinion, but using the -only / -or-later variant makes a
lot of sense.
> If so, I'll submit a checkpatch patch.
No objections, but we please have to make it clear that this is not a new
playground for s/OLDSTYLE/NEWSTYLE/ scriptkiddies.
The compliance tools have to understand both anyway.
> I could also wire up a patch to checkpatch and docs to
> remove the /* */
> requirement for .h files and prefer
> the generic // form for both .c and
> .h files as the
> current minimum tooling versions now all allow //
> comments
Yes, that makes sense. The restriction is not longer relevant, but again we
are not changing all the existing files for no reason.
Thanks,
tglx
next prev parent reply other threads:[~2019-05-22 10:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190521133257.GA21471@kroah.com>
2019-05-21 19:55 ` [GIT PULL] SPDX update for 5.2-rc1 - round 1 pr-tracker-bot
2019-05-21 19:56 ` Linus Torvalds
2019-05-22 16:34 ` Greg KH
2019-05-22 4:32 ` Masahiro Yamada
2019-05-22 6:34 ` Joe Perches
2019-05-22 10:14 ` Thomas Gleixner [this message]
2019-05-23 2:49 ` Masahiro Yamada
2019-05-23 2:57 ` Joe Perches
2019-05-23 5:33 ` Thomas Gleixner
2019-06-25 11:19 ` Masahiro Yamada
2019-05-29 13:13 ` Alexandre Belloni
2019-05-29 13:51 ` Thomas Gleixner
2019-05-29 14:16 ` Zavras, Alexios
[not found] ` <B03F305C-F579-43E1-BEE7-D628BD44FF48@jilayne.com>
2019-05-31 0:25 ` J Lovejoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1905221210340.1637@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).