From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707E1C7618B for ; Thu, 25 Jul 2019 08:40:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34E962238C for ; Thu, 25 Jul 2019 08:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389705AbfGYIkK (ORCPT ); Thu, 25 Jul 2019 04:40:10 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:45595 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389213AbfGYIkK (ORCPT ); Thu, 25 Jul 2019 04:40:10 -0400 Received: from pd9ef1cb8.dip0.t-ipconnect.de ([217.239.28.184] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hqZIF-0001Gq-Ge; Thu, 25 Jul 2019 10:40:07 +0200 Date: Thu, 25 Jul 2019 10:40:06 +0200 (CEST) From: Thomas Gleixner To: Masahiro Yamada cc: linux-kernel@vger.kernel.org, linux-spdx@vger.kernel.org, Greg KH , alsa-devel@alsa-project.org Subject: Re: [PATCH v2 1/3] treewide: add "WITH Linux-syscall-note" to SPDX tag of uapi headers In-Reply-To: <20190725075833.3481-1-yamada.masahiro@socionext.com> Message-ID: References: <20190725075833.3481-1-yamada.masahiro@socionext.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org On Thu, 25 Jul 2019, Masahiro Yamada wrote: > UAPI headers licensed under GPL are supposed to have exception > "WITH Linux-syscall-note" so that they can be included into non-GPL > user space application code. > > The exception note is missing in some UAPI headers. > > Some of them slipped in by the treewide conversion commit b24413180f56 > ("License cleanup: add SPDX GPL-2.0 license identifier to files with > no license"). Just run: > > $ git show --oneline b24413180f56 -- arch/x86/include/uapi/asm/ > > I believe they are not intentional, and should be fixed too. > > This patch was generated by the following script: > > git grep -l --not -e Linux-syscall-note --and -e SPDX-License-Identifier \ > -- :arch/*/include/uapi/asm/*.h :include/uapi/ :^*/Kbuild | > while read file > do > sed -i -e '/[[:space:]]OR[[:space:]]/s/\(GPL-[^[:space:]]*\)/(\1 WITH Linux-syscall-note)/g' \ > -e '/[[:space:]]or[[:space:]]/s/\(GPL-[^[:space:]]*\)/(\1 WITH Linux-syscall-note)/g' \ > -e '/[[:space:]]OR[[:space:]]/!{/[[:space:]]or[[:space:]]/!s/\(GPL-[^[:space:]]*\)/\1 WITH Linux-syscall-note/g}' $file > done > > After this patch is applied, there are 5 UAPI headers that do not contain > "WITH Linux-syscall-note". They are kept untouched since this exception > applies only to GPL variants. > > $ git grep --not -e Linux-syscall-note --and -e SPDX-License-Identifier \ > -- :arch/*/include/uapi/asm/*.h :include/uapi/ :^*/Kbuild > include/uapi/drm/panfrost_drm.h:/* SPDX-License-Identifier: MIT */ > include/uapi/linux/batman_adv.h:/* SPDX-License-Identifier: MIT */ > include/uapi/linux/qemu_fw_cfg.h:/* SPDX-License-Identifier: BSD-3-Clause */ > include/uapi/linux/vbox_err.h:/* SPDX-License-Identifier: MIT */ > include/uapi/linux/virtio_iommu.h:/* SPDX-License-Identifier: BSD-3-Clause */ > > Signed-off-by: Masahiro Yamada Thanks for cleaning this up! Reviewed-by: Thomas Gleixner