Linux-SPDX Archive on lore.kernel.org
 help / color / Atom feed
* License clarification of sound/soc/qcom/qdsp6/q6afe-clocks.c
@ 2020-09-26 17:01 Lukas Bulwahn
  2020-09-26 17:19 ` Srinivas Kandagatla
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2020-09-26 17:01 UTC (permalink / raw)
  To: Srinivas Kandagatla
  Cc: Mark Brown, devicetree, alsa-devel, linux-kernel, linux-spdx

Dear Srinivas,

with commit 520a1c396d19 ("ASoC: q6afe-clocks: add q6afe clock 
controller"), you have added the file sound/soc/qcom/qdsp6/q6afe-clocks.c 
with the SPDX-License-Identifier: GPL-1.0.

The use of 'GPL-1.0 only' is strongly not recommended as the Usage-Guide 
in ./LICENSES/deprecated/GPL-1.0 points out:

  The GNU General Public License (GPL) version 1 should not be used in new
  code. For existing kernel code the 'or any later version' option is
  required to be compatible with the general license of the project: GPLv2.

At the end of the file, you further state it licensed with GPL-2.0 with 
the following line:

MODULE_LICENSE("GPL v2");

So, is this just a typo in the SPDX-License-Identifier or do you really 
intend to license this file under GPL-1.0 only?


Best regards,

Lukas

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: License clarification of sound/soc/qcom/qdsp6/q6afe-clocks.c
  2020-09-26 17:01 License clarification of sound/soc/qcom/qdsp6/q6afe-clocks.c Lukas Bulwahn
@ 2020-09-26 17:19 ` Srinivas Kandagatla
  0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2020-09-26 17:19 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Mark Brown, devicetree, alsa-devel, linux-kernel, linux-spdx


Thanks Lukas for spotting this,


On 26/09/2020 18:01, Lukas Bulwahn wrote:
> At the end of the file, you further state it licensed with GPL-2.0 with
> the following line:
> 
> MODULE_LICENSE("GPL v2");
> 
> So, is this just a typo in the SPDX-License-Identifier or do you really
> intend to license this file under GPL-1.0 only?

yes, this was totally unintended typo from my side, Just sent a patch to 
fix this!

thanks,
srini

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-26 17:01 License clarification of sound/soc/qcom/qdsp6/q6afe-clocks.c Lukas Bulwahn
2020-09-26 17:19 ` Srinivas Kandagatla

Linux-SPDX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spdx/0 linux-spdx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spdx linux-spdx/ https://lore.kernel.org/linux-spdx \
		linux-spdx@vger.kernel.org
	public-inbox-index linux-spdx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spdx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git