From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lukas Wunner <lukas@wunner.de>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, Tsuchiya Yuto <kitakar@gmail.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH 3/3] spi: pxa2xx: Fix runtime PM ref imbalance on probe error
Date: Tue, 26 May 2020 11:46:57 +0300 [thread overview]
Message-ID: <049b3538-bb0b-89a0-dae7-09b2e950db6c@linux.intel.com> (raw)
In-Reply-To: <20200525131244.GV1634618@smile.fi.intel.com>
On 5/25/20 4:12 PM, Andy Shevchenko wrote:
> On Mon, May 25, 2020 at 02:25:03PM +0200, Lukas Wunner wrote:
>> The PXA2xx SPI driver releases a runtime PM ref in the probe error path
>> even though it hasn't acquired a ref earlier.
>>
>> Apparently commit e2b714afee32 ("spi: pxa2xx: Disable runtime PM if
>> controller registration fails") sought to copy-paste the invocation of
>> pm_runtime_disable() from pxa2xx_spi_remove(), but erroneously copied
>> the call to pm_runtime_put_noidle() as well. Drop it.
>
> Looks like correct fix to me.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
Yes, I think it was blind copy-paste from pxa2xx_spi_remove() where
pm_runtime_put_noidle() is needed due the pm_runtime_get_sync() call but
not in pxa2xx_spi_probe().
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2020-05-26 8:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 12:25 [PATCH 0/3] Intel SPI unbind fixes Lukas Wunner
2020-05-25 12:25 ` [PATCH 1/3] spi: dw: Fix controller unregister order Lukas Wunner
2020-05-25 13:15 ` Andy Shevchenko
2020-05-25 12:25 ` [PATCH 2/3] spi: pxa2xx: " Lukas Wunner
2020-05-25 13:21 ` Andy Shevchenko
2020-05-26 7:39 ` Lukas Wunner
2020-05-26 8:22 ` Andy Shevchenko
2020-05-27 12:09 ` Tsuchiya Yuto
2020-05-27 12:27 ` Andy Shevchenko
2020-05-27 13:14 ` Tsuchiya Yuto
2020-05-28 7:02 ` Tsuchiya Yuto
2020-05-28 8:41 ` Andy Shevchenko
2020-05-28 9:31 ` Lukas Wunner
2020-05-29 13:54 ` Tsuchiya Yuto
2020-05-25 12:25 ` [PATCH 3/3] spi: pxa2xx: Fix runtime PM ref imbalance on probe error Lukas Wunner
2020-05-25 13:12 ` Andy Shevchenko
2020-05-26 8:46 ` Jarkko Nikula [this message]
2020-05-25 13:23 ` [PATCH 0/3] Intel SPI unbind fixes Andy Shevchenko
2020-05-26 16:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=049b3538-bb0b-89a0-dae7-09b2e950db6c@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=kitakar@gmail.com \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).