* [PATCH] spi: imx: Don't print error on -EPROBEDEFER
@ 2021-01-18 16:31 Guido Günther
2021-01-18 19:29 ` Fabio Estevam
0 siblings, 1 reply; 2+ messages in thread
From: Guido Günther @ 2021-01-18 16:31 UTC (permalink / raw)
To: Mark Brown, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Trent Piepho, Oleksij Rempel,
linux-spi, linux-arm-kernel, linux-kernel
This avoids
[ 0.962538] spi_imx 30820000.spi: bitbang start failed with -517
durig driver probe.
Fixes: 8197f489f4c4 ("spi: imx: Fix failure path leak on GPIO request error correctly")
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
drivers/spi/spi-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 73ca821763d6..5dc4ea4b4450 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -1685,7 +1685,7 @@ static int spi_imx_probe(struct platform_device *pdev)
master->dev.of_node = pdev->dev.of_node;
ret = spi_bitbang_start(&spi_imx->bitbang);
if (ret) {
- dev_err(&pdev->dev, "bitbang start failed with %d\n", ret);
+ dev_err_probe(&pdev->dev, ret, "bitbang start failed\n");
goto out_bitbang_start;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: imx: Don't print error on -EPROBEDEFER
2021-01-18 16:31 [PATCH] spi: imx: Don't print error on -EPROBEDEFER Guido Günther
@ 2021-01-18 19:29 ` Fabio Estevam
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2021-01-18 19:29 UTC (permalink / raw)
To: Guido Günther
Cc: Mark Brown, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
NXP Linux Team, Trent Piepho, Oleksij Rempel, linux-spi,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
On Mon, Jan 18, 2021 at 1:31 PM Guido Günther <agx@sigxcpu.org> wrote:
>
> This avoids
>
> [ 0.962538] spi_imx 30820000.spi: bitbang start failed with -517
>
> durig driver probe.
>
> Fixes: 8197f489f4c4 ("spi: imx: Fix failure path leak on GPIO request error correctly")
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-18 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 16:31 [PATCH] spi: imx: Don't print error on -EPROBEDEFER Guido Günther
2021-01-18 19:29 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).