From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Joakim Tjernlund" Subject: RE: [PATCH 1/2] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe() Date: Wed, 23 Apr 2008 23:55:11 +0200 Message-ID: <1180.73926209963$1208987852@news.gmane.org> References: <480FA234.1000601@tiscali.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general@lists.sourceforge.net, dbrownell@users.sourceforge.net, 'lkml' To: "'Roel Kluin'" <12o3l@tiscali.nl>, , Return-path: In-Reply-To: <480FA234.1000601@tiscali.nl> Content-Language: sv List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org List-Id: linux-spi.vger.kernel.org > -----Original Message----- > From: linuxppc-dev-bounces+joakim.tjernlund=transmode.se@ozlabs.org [mailto:linuxppc-dev- > bounces+joakim.tjernlund=transmode.se@ozlabs.org] On Behalf Of Roel Kluin > Sent: den 23 april 2008 22:55 > To: galak@kernel.crashing.org; linuxppc-dev@ozlabs.org > Cc: spi-devel-general@lists.sourceforge.net; dbrownell@users.sourceforge.net; lkml > Subject: [PATCH 1/2] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe() > > mpc83xx_spi->irq is unsigned, so the test fails > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> hmm, I got a pretty large 83xx spi patch queued at dbrownell. I hope that one can be applied first. Then you probably need to rediff this patch. David, any progress on my patch? Jocke > --- > diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c > index be15a62..033fd51 100644 > --- a/drivers/spi/spi_mpc83xx.c > +++ b/drivers/spi/spi_mpc83xx.c > @@ -454,12 +454,12 @@ static int __init mpc83xx_spi_probe(struct platform_device *dev) > goto put_master; > } > > - mpc83xx_spi->irq = platform_get_irq(dev, 0); > - > - if (mpc83xx_spi->irq < 0) { > - ret = -ENXIO; > + ret = platform_get_irq(dev, 0); > + if (ret < 0) > goto unmap_io; > - } > + > + mpc83xx_spi->irq = ret; > + ret = 0; > > /* Register for SPI Interrupt */ > ret = request_irq(mpc83xx_spi->irq, mpc83xx_spi_irq, > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev >