From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C36FC2BA1A for ; Fri, 24 Apr 2020 09:12:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6859F2074F for ; Fri, 24 Apr 2020 09:12:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbgDXJM2 (ORCPT ); Fri, 24 Apr 2020 05:12:28 -0400 Received: from mx.socionext.com ([202.248.49.38]:38499 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbgDXJM2 (ORCPT ); Fri, 24 Apr 2020 05:12:28 -0400 Received: from unknown (HELO iyokan-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 24 Apr 2020 18:12:26 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan-ex.css.socionext.com (Postfix) with ESMTP id 5A66E60057; Fri, 24 Apr 2020 18:12:26 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Fri, 24 Apr 2020 18:12:26 +0900 Received: from yuzu.css.socionext.com (yuzu [172.31.8.45]) by kinkan.css.socionext.com (Postfix) with ESMTP id 2AD8F1A12D0; Fri, 24 Apr 2020 18:12:26 +0900 (JST) Received: from [10.212.22.225] (unknown [10.212.22.225]) by yuzu.css.socionext.com (Postfix) with ESMTP id 6F879120131; Fri, 24 Apr 2020 18:12:25 +0900 (JST) Subject: Re: [PATCH] dt-bindings: spi: Convert UniPhier SPI controller to json-schema To: Mark Brown , Rob Herring , Masahiro Yamada Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1587087014-14598-1-git-send-email-hayashi.kunihiko@socionext.com> From: Kunihiko Hayashi Message-ID: <1243a377-cb88-3fa5-fcf9-75da200d9a9c@socionext.com> Date: Fri, 24 Apr 2020 18:12:24 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1587087014-14598-1-git-send-email-hayashi.kunihiko@socionext.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 2020/04/17 10:30, Kunihiko Hayashi wrote: > Convert UniPhier SPI controller binding to DT schema format. > > Signed-off-by: Kunihiko Hayashi > --- > .../bindings/spi/socionext,uniphier-spi.yaml | 55 ++++++++++++++++++++++ > .../devicetree/bindings/spi/spi-uniphier.txt | 28 ----------- > 2 files changed, 55 insertions(+), 28 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml > delete mode 100644 Documentation/devicetree/bindings/spi/spi-uniphier.txt > > diff --git a/Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml b/Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml > new file mode 100644 > index 0000000..bab8bcc > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/socionext,uniphier-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Socionext UniPhier SPI controller > + > +description: | > + UniPhier SoCs have SCSSI which supports SPI single channel. > + > +maintainers: > + - Kunihiko Hayashi > + - Keiji Hayashibara > + > +allOf: > + - $ref: spi-controller.yaml# > + > +properties: > + "#address-cells": true > + "#size-cells": true > + > + compatible: > + const: socionext,uniphier-scssi > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - resets According to spi-controller.yaml, the "#address-cells" is required. And the "#size-cells" is also required because it specifies "const: 0". I'll add them in v2. Thank you, --- Best Regards Kunihiko Hayashi