From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: David Vrabel <dvrabel@arcom.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
David Brownell <dbrownell@users.sourceforge.net>,
Grant Likely <grant.likely@secretlab.ca>,
Kumar Gala <galak@kernel.crashing.org>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Andrew Morton <akpm@linux-foundation.org>,
spi-devel-general@lists.sourceforge.net
Subject: [PATCH 6/7] spi/mpc8xxx: don't check platform_get_irq's return value against zero
Date: Wed, 16 Dec 2009 17:10:08 +0100 [thread overview]
Message-ID: <1260979809-24811-6-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <1260979809-24811-5-git-send-email-u.kleine-koenig@pengutronix.de>
platform_get_irq returns -ENXIO on failure, so !irq was probably
always true. Better use (int)irq <= 0. Note that a return value of
zero is still handled as error even though this could mean irq0.
This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: David Vrabel <dvrabel@arcom.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Kumar Gala <galak@kernel.crashing.org>
Cc: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: spi-devel-general@lists.sourceforge.net
---
drivers/spi/spi_mpc8xxx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c
index e9390d7..b13501a 100644
--- a/drivers/spi/spi_mpc8xxx.c
+++ b/drivers/spi/spi_mpc8xxx.c
@@ -1339,7 +1339,7 @@ static int __devinit plat_mpc8xxx_spi_probe(struct platform_device *pdev)
return -EINVAL;
irq = platform_get_irq(pdev, 0);
- if (!irq)
+ if ((int)irq <= 0)
return -EINVAL;
master = mpc8xxx_spi_probe(&pdev->dev, mem, irq);
--
1.6.5.2
next parent reply other threads:[~2009-12-16 16:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1260979809-24811-1-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1260979809-24811-2-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1260979809-24811-3-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1260979809-24811-4-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1260979809-24811-5-git-send-email-u.kleine-koenig@pengutronix.de>
2009-12-16 16:10 ` Uwe Kleine-König [this message]
2009-12-16 16:32 ` [PATCH 6/7] spi/mpc8xxx: don't check platform_get_irq's return value against zero Anton Vorontsov
2009-12-16 17:49 ` Uwe Kleine-König
2009-12-16 18:20 ` Anton Vorontsov
2009-12-16 19:18 ` Uwe Kleine-König
2009-12-16 19:37 ` Anton Vorontsov
2009-12-16 19:51 ` Anton Vorontsov
2009-12-17 13:05 ` Uwe Kleine-König
2009-12-17 16:25 ` Anton Vorontsov
2009-12-16 18:20 ` David Vrabel
2009-12-17 16:39 ` Anton Vorontsov
2009-12-19 15:13 ` [PATCH] " Uwe Kleine-König
2010-01-13 11:05 ` [RESEND PATCH 5/5] " Uwe Kleine-König
2010-01-13 11:17 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260979809-24811-6-git-send-email-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=dbrownell@users.sourceforge.net \
--cc=dvrabel@arcom.com \
--cc=galak@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).