From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Subject: [RESEND PATCH 5/5] spi/mpc8xxx: don't check platform_get_irq's return value against zero Date: Wed, 13 Jan 2010 12:05:46 +0100 Message-ID: <1263380746-27803-5-git-send-email-u.kleine-koenig@pengutronix.de> References: <1260979809-24811-1-git-send-email-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Vrabel , Greg Kroah-Hartman , David Brownell , Grant Likely , Kumar Gala , Anton Vorontsov , Andrew Morton , spi-devel-general@lists.sourceforge.net To: linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1260979809-24811-1-git-send-email-u.kleine-koenig@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org platform_get_irq returns -ENXIO on failure, so !irq was probably always true. Make irq a signed variable and compare irq <=3D 0. Note that a return value of zero is still handled as error even though this could mean irq0. This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that changed the return value of platform_get_irq from 0 to -ENXIO on error. Signed-off-by: Uwe Kleine-K=C3=B6nig Cc: David Vrabel Cc: Greg Kroah-Hartman Cc: David Brownell Cc: Grant Likely Cc: Kumar Gala Cc: Anton Vorontsov Cc: Andrew Morton Cc: spi-devel-general@lists.sourceforge.net --- drivers/spi/spi_mpc8xxx.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c index 1fb2a6e..08065fb 100644 --- a/drivers/spi/spi_mpc8xxx.c +++ b/drivers/spi/spi_mpc8xxx.c @@ -1328,7 +1328,7 @@ static struct of_platform_driver of_mpc8xxx_spi_d= river =3D { static int __devinit plat_mpc8xxx_spi_probe(struct platform_device *pd= ev) { struct resource *mem; - unsigned int irq; + int irq; struct spi_master *master; =20 if (!pdev->dev.platform_data) @@ -1339,7 +1339,7 @@ static int __devinit plat_mpc8xxx_spi_probe(struc= t platform_device *pdev) return -EINVAL; =20 irq =3D platform_get_irq(pdev, 0); - if (!irq) + if (irq <=3D 0) return -EINVAL; =20 master =3D mpc8xxx_spi_probe(&pdev->dev, mem, irq); --=20 1.6.6