linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Scott Ellis <scott@jumpnowtek.com>
To: spi-devel-general@lists.sourceforge.net
Cc: TonyLindgren <tony@atomide.com>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Grant Likely <grant.likely@secretlab.ca>,
	Andrew Morton <akpm@linux-foundation.org>,
	Roman Tereshonkov <roman.tereshonkov@nokia.com>,
	linux-omap@vger.kernel.org,
	Aaro Koskinen <Aaro.Koskinen@nokia.com>,
	Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH 2/6 Revised] SPI omap2_mcspi: Add max_clk_div field to mcspi platform config
Date: Fri, 19 Mar 2010 15:46:31 -0400	[thread overview]
Message-ID: <1269027991.586.63.camel@quad> (raw)
In-Reply-To: <20100315210236.GE2900@atomide.com>

> Only 3430 and 3630 TRMs says 0xd, 0xe, 0xf = Division not supported.
> 
I tested a 3503 with clock divider values of 0x0d, 0x0e and 0x0f.
It worked fine.
I collected data off the SPI bus successfully at the expected
frequencies of 5859 Hz, 2929 Hz and 1464 Hz.

> But then again, the TRMs can have errors.
> 
Looks like this is a case of that. 

My patches #2 and #3 are unnecessary then and #4 makes use of a new 
field added in #3.

I can resubmit #4, "Use transfer speed_hz if provided". That was the 
original problem I was working on. 

Should I leave the hard-coded 0x0f in the code or would you prefer a
named constant?




  reply	other threads:[~2010-03-19 19:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-12 15:21 [PATCH 2/6] SPI omap2_mcspi: Add max_clk_div field to mcspi platform config Scott Ellis
2010-03-12 17:21 ` Tony Lindgren
2010-03-14 17:25   ` [PATCH 2/6 Revised] " Scott Ellis
2010-03-15 16:32     ` Tony Lindgren
2010-03-15 18:03       ` Felipe Balbi
2010-03-15 18:52         ` Tony Lindgren
2010-03-15 19:16           ` Felipe Balbi
2010-03-15 19:29             ` Tony Lindgren
2010-03-15 19:31               ` Felipe Balbi
2010-03-15 20:06                 ` Tony Lindgren
2010-03-15 20:30       ` Scott Ellis
2010-03-15 21:02         ` Tony Lindgren
2010-03-19 19:46           ` Scott Ellis [this message]
2010-03-19 20:38             ` Tony Lindgren
2010-05-24 14:26               ` Scott Ellis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269027991.586.63.camel@quad \
    --to=scott@jumpnowtek.com \
    --cc=Aaro.Koskinen@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=grant.likely@secretlab.ca \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=roman.tereshonkov@nokia.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).