From: Icenowy Zheng <icenowy@aosc.io>
To: Samuel Holland <samuel@sholland.org>,
Mark Brown <broonie@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maxime Ripard <mripard@kernel.org>
Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] spi: sun6i: add support for R329 SPI controllers
Date: Sat, 23 Apr 2022 08:01:00 +0800 [thread overview]
Message-ID: <1285f34e9b1b02f6808cd7c51abadc1bf178c2fe.camel@aosc.io> (raw)
In-Reply-To: <0b5b586a-3bc7-384e-103c-e40d0b2fac23@sholland.org>
在 2022-04-22星期五的 18:59 -0500，Samuel Holland写道：
> On 4/22/22 10:56 AM, icenowy@outlook.com wrote:
> > From: Icenowy Zheng <icenowy@aosc.io>
> >
> > R329 has two SPI controllers. One of it is quite similar to
> > previous
> > ones, but with internal clock divider removed; the other added MIPI
> > DBI
> > Type-C offload based on the first one.
> >
> > Add basical support for these controllers. As we're not going to
> > support the DBI functionality now, just implement the two kinds of
> > controllers as the same.
>
> I'm curious what speeds you were able to use SPI at. On D1, with
> effectively
> these same changes, I would always get corrupted data when reading
> from the
> onboard SPI NAND on the Nezha board. However, if I enabled the "new
> mode of
> sample timing" (bit 2 in GBL_CTL_REG), I got the correct data.
Oh my usage never read from device now, because it's a write-only MIPI
DBI panel.
>
> Regards,
> Samuel
next prev parent reply other threads:[~2022-04-23 5:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220422155639.1071645-1-icenowy@outlook.com>
2022-04-22 15:56 ` [PATCH 1/4] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329 SPI icenowy
2022-04-22 23:49 ` Samuel Holland
2022-04-23 0:10 ` Icenowy Zheng
2022-04-22 15:56 ` [PATCH 2/4] spi: sun6i: change OF match data to a struct icenowy
2022-04-22 23:50 ` Samuel Holland
2022-04-22 15:56 ` [PATCH 3/4] spi: sun6i: add quirk for in-controller clock divider icenowy
2022-04-22 23:54 ` Samuel Holland
2022-04-22 23:57 ` Icenowy Zheng
2022-04-22 15:56 ` [PATCH 4/4] spi: sun6i: add support for R329 SPI controllers icenowy
2022-04-22 23:59 ` Samuel Holland
2022-04-23 0:01 ` Icenowy Zheng [this message]
2022-04-23 0:07 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285f34e9b1b02f6808cd7c51abadc1bf178c2fe.camel@aosc.io \
--to=icenowy@aosc.io \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).