linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
	David Brownell
	<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: [PATCH 19/49] spi: davinci: simplify calculation of edma acount value
Date: Wed, 17 Nov 2010 16:13:51 +0530	[thread overview]
Message-ID: <1289990661-30126-20-git-send-email-nsekhar@ti.com> (raw)
In-Reply-To: <1289990661-30126-19-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>

From: Brian Niebuhr <bniebuhr-JaPwekKOx1yaMJb+Lgu22Q@public.gmane.org>

The EDMA acount (called data_type in davinci_spi_bufs_dma())
is simply the bytes_per_word obtained in the transfer setup
function. The current code calculates the acount value from
bytes_per_word in a convoluted manner. Simplify the code.

Signed-off-by: Brian Niebuhr <bniebuhr-JaPwekKOx1yaMJb+Lgu22Q@public.gmane.org>
Tested-By: Michael Williamson <michael.williamson-wZX4cNJlHJ2sVWG7oymsAA@public.gmane.org>
Signed-off-by: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
---
 drivers/spi/davinci_spi.c |   25 +++----------------------
 1 files changed, 3 insertions(+), 22 deletions(-)

diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c
index f1c3502..b0b338f 100644
--- a/drivers/spi/davinci_spi.c
+++ b/drivers/spi/davinci_spi.c
@@ -39,9 +39,6 @@
 #define CS_DEFAULT	0xFF
 
 #define SPI_BUFSIZ	(SMP_CACHE_BYTES + 1)
-#define DAVINCI_DMA_DATA_TYPE_S8	0x01
-#define DAVINCI_DMA_DATA_TYPE_S16	0x02
-#define DAVINCI_DMA_DATA_TYPE_S32	0x04
 
 #define SPIFMT_PHASE_MASK	BIT(16)
 #define SPIFMT_POLARITY_MASK	BIT(17)
@@ -729,19 +726,14 @@ static int davinci_spi_bufs_pio(struct spi_device *spi, struct spi_transfer *t)
 	return t->len;
 }
 
-#define DAVINCI_DMA_DATA_TYPE_S8	0x01
-#define DAVINCI_DMA_DATA_TYPE_S16	0x02
-#define DAVINCI_DMA_DATA_TYPE_S32	0x04
-
 static int davinci_spi_bufs_dma(struct spi_device *spi, struct spi_transfer *t)
 {
 	struct davinci_spi *davinci_spi;
 	int int_status = 0;
 	int count, temp_count;
-	u8 conv = 1;
 	u32 data1_reg_val;
 	struct davinci_spi_dma *davinci_spi_dma;
-	int word_len, data_type, ret;
+	int data_type, ret;
 	unsigned long tx_reg, rx_reg;
 	struct device *sdev;
 
@@ -757,8 +749,8 @@ static int davinci_spi_bufs_dma(struct spi_device *spi, struct spi_transfer *t)
 	davinci_spi->rx = t->rx_buf;
 
 	/* convert len to words based on bits_per_word */
-	conv = davinci_spi->bytes_per_word[spi->chip_select];
-	davinci_spi->count = t->len / conv;
+	data_type = davinci_spi->bytes_per_word[spi->chip_select];
+	davinci_spi->count = t->len / data_type;
 
 	data1_reg_val = ioread32(davinci_spi->base + SPIDAT1);
 
@@ -767,17 +759,6 @@ static int davinci_spi_bufs_dma(struct spi_device *spi, struct spi_transfer *t)
 	init_completion(&davinci_spi_dma->dma_rx_completion);
 	init_completion(&davinci_spi_dma->dma_tx_completion);
 
-	word_len = conv * 8;
-
-	if (word_len <= 8)
-		data_type = DAVINCI_DMA_DATA_TYPE_S8;
-	else if (word_len <= 16)
-		data_type = DAVINCI_DMA_DATA_TYPE_S16;
-	else if (word_len <= 32)
-		data_type = DAVINCI_DMA_DATA_TYPE_S32;
-	else
-		return -EINVAL;
-
 	ret = davinci_spi_bufs_prep(spi, davinci_spi);
 	if (ret)
 		return ret;
-- 
1.7.3.2

  parent reply	other threads:[~2010-11-17 10:43 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 10:43 [PATCH 00/49] spi: davinci: re-write existing driver Sekhar Nori
     [not found] ` <1289990661-30126-1-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43   ` [PATCH 01/49] spi: davinci: fix checkpatch errors Sekhar Nori
     [not found]     ` <1289990661-30126-2-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43       ` [PATCH 02/49] spi: davinci: whitespace cleanup Sekhar Nori
     [not found]         ` <1289990661-30126-3-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43           ` [PATCH 03/49] spi: davinci: remove unused variable 'pdata' Sekhar Nori
     [not found]             ` <1289990661-30126-4-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43               ` [PATCH 04/49] spi: davinci: removed unused #defines Sekhar Nori
     [not found]                 ` <1289990661-30126-5-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                   ` [PATCH 05/49] spi: davinci: remove unnecessary typecast Sekhar Nori
     [not found]                     ` <1289990661-30126-6-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                       ` [PATCH 06/49] spi: davinci: set chip-select mode in SPIDEF only once Sekhar Nori
     [not found]                         ` <1289990661-30126-7-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                           ` [PATCH 07/49] spi: davinci: enable both activation and deactivation of chip-selects Sekhar Nori
     [not found]                             ` <1289990661-30126-8-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                               ` [PATCH 08/49] spi: davinci: remove unnecessary data transmit on CS disable Sekhar Nori
     [not found]                                 ` <1289990661-30126-9-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                   ` [PATCH 09/49] spi: davinci: enable GPIO lines to be used as chip selects Sekhar Nori
     [not found]                                     ` <1289990661-30126-10-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                       ` [PATCH 10/49] spi: davinci: simplify prescalar calculation Sekhar Nori
     [not found]                                         ` <1289990661-30126-11-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                           ` [PATCH 11/49] spi: davinci: remove 'wait_enable' platform data member Sekhar Nori
     [not found]                                             ` <1289990661-30126-12-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                               ` [PATCH 12/49] spi: davinci: make chip-slect specific parameters really chip-select specific Sekhar Nori
     [not found]                                                 ` <1289990661-30126-13-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                   ` [PATCH 13/49] spi: davinci: consolidate setup of SPIFMTn in one function Sekhar Nori
     [not found]                                                     ` <1289990661-30126-14-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                       ` [PATCH 14/49] spi: davinci: setup chip-select timers values only if timer enabled Sekhar Nori
     [not found]                                                         ` <1289990661-30126-15-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                           ` [PATCH 15/49] spi: davinci: add support for wait enable timeouts Sekhar Nori
     [not found]                                                             ` <1289990661-30126-16-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                               ` [PATCH 16/49] spi: davinci: remove unused members of davinci_spi_slave Sekhar Nori
     [not found]                                                                 ` <1289990661-30126-17-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                   ` [PATCH 17/49] spi: davinci: eliminate the single member structure davinci_spi_slave Sekhar Nori
     [not found]                                                                     ` <1289990661-30126-18-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                       ` [PATCH 18/49] spi: davinci: eliminate unnecessary update of davinci_spi->count Sekhar Nori
     [not found]                                                                         ` <1289990661-30126-19-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                           ` Sekhar Nori [this message]
     [not found]                                                                             ` <1289990661-30126-20-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                               ` [PATCH 20/49] spi: davinci: check for NULL buffer pointer before using it Sekhar Nori
     [not found]                                                                                 ` <1289990661-30126-21-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                                   ` [PATCH 21/49] spi: davinci: remove unnecessary disable of SPI Sekhar Nori
     [not found]                                                                                     ` <1289990661-30126-22-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                                       ` [PATCH 22/49] spi: davinci: remove unnecessary 'count' variable in driver private data Sekhar Nori
     [not found]                                                                                         ` <1289990661-30126-23-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                                           ` [PATCH 23/49] spi: davinci: do not treat Tx interrupt being set as error Sekhar Nori
     [not found]                                                                                             ` <1289990661-30126-24-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                                               ` [PATCH 24/49] spi: davinci: remove unnecessary completion variable initialization Sekhar Nori
     [not found]                                                                                                 ` <1289990661-30126-25-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                                                   ` [PATCH 25/49] spi: davinci: remove non-useful interrupt mode support Sekhar Nori
     [not found]                                                                                                     ` <1289990661-30126-26-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                                                       ` [PATCH 26/49] spi: davinci: simplify poll mode transfers Sekhar Nori
     [not found]                                                                                                         ` <1289990661-30126-27-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:43                                                                                                           ` [PATCH 27/49] spi: davinci: add support for interrupt mode Sekhar Nori
     [not found]                                                                                                             ` <1289990661-30126-28-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                               ` [PATCH 28/49] spi: davinci: configure the invariable bits in spipc0 only once Sekhar Nori
     [not found]                                                                                                                 ` <1289990661-30126-29-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                   ` [PATCH 29/49] spi: davinci: remove unnecessary function davinci_spi_bufs_prep() Sekhar Nori
     [not found]                                                                                                                     ` <1289990661-30126-30-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                       ` [PATCH 30/49] spi: davinci: remove unnecessary call to davinci_spi_setup_transfer() Sekhar Nori
     [not found]                                                                                                                         ` <1289990661-30126-31-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                           ` [PATCH 31/49] spi: davinci: do not store DMA channel information per chip select Sekhar Nori
     [not found]                                                                                                                             ` <1289990661-30126-32-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                               ` [PATCH 32/49] spi: davinci: always start transmit DMA Sekhar Nori
     [not found]                                                                                                                                 ` <1289990661-30126-33-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                   ` [PATCH 33/49] spi: davinci: do not use temporary buffer if no transmit data provided Sekhar Nori
     [not found]                                                                                                                                     ` <1289990661-30126-34-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                       ` [PATCH 34/49] spi: davinci: always start receive DMA Sekhar Nori
     [not found]                                                                                                                                         ` <1289990661-30126-35-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                           ` [PATCH 35/49] spi: davinci: use edma_write_slot() to setup EDMA PaRAM slot Sekhar Nori
     [not found]                                                                                                                                             ` <1289990661-30126-36-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                               ` [PATCH 36/49] spi: davinci: fix DMA event generation stoppage Sekhar Nori
     [not found]                                                                                                                                                 ` <1289990661-30126-37-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                   ` [PATCH 37/49] spi: davinci: do not allocate DMA channels during SPI device setup Sekhar Nori
     [not found]                                                                                                                                                     ` <1289990661-30126-38-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                       ` [PATCH 38/49] spi: davinci: fix EDMA CC errors at end of transfers Sekhar Nori
     [not found]                                                                                                                                                         ` <1289990661-30126-39-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                           ` [PATCH 39/49] spi: davinci: handle DMA completion errors correctly Sekhar Nori
     [not found]                                                                                                                                                             ` <1289990661-30126-40-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                               ` [PATCH 40/49] spi: davinci: remove usage of additional completion variables for DMA Sekhar Nori
     [not found]                                                                                                                                                                 ` <1289990661-30126-41-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                                   ` [PATCH 41/49] spi: davinci: let DMA operation be specified on per-device basis Sekhar Nori
     [not found]                                                                                                                                                                     ` <1289990661-30126-42-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                                       ` [PATCH 42/49] spi: davinci: remove non-useful "clk_internal" platform data Sekhar Nori
     [not found]                                                                                                                                                                         ` <1289990661-30126-43-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                                           ` [PATCH 43/49] spi: davinci: enable and power-up SPI only when required Sekhar Nori
     [not found]                                                                                                                                                                             ` <1289990661-30126-44-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                                               ` [PATCH 44/49] spi: davinci: setup the driver owner Sekhar Nori
     [not found]                                                                                                                                                                                 ` <1289990661-30126-45-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                                                   ` [PATCH 45/49] spi: davinci: add additional comments Sekhar Nori
     [not found]                                                                                                                                                                                     ` <1289990661-30126-46-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                                                       ` [PATCH 46/49] spi: davinci: add EF Johnson Technologies copyright Sekhar Nori
     [not found]                                                                                                                                                                                         ` <1289990661-30126-47-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                                                           ` [PATCH 47/49] spi: davinci: remove unnecessary private data member 'region_size' Sekhar Nori
     [not found]                                                                                                                                                                                             ` <1289990661-30126-48-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                                                               ` [PATCH 48/49] spi: davinci: shorten variable names Sekhar Nori
     [not found]                                                                                                                                                                                                 ` <1289990661-30126-49-git-send-email-nsekhar-l0cyMroinI0@public.gmane.org>
2010-11-17 10:44                                                                                                                                                                                                   ` [PATCH 49/49] spi: davinci: kconfig: add manufacturer name to prompt string Sekhar Nori
2010-11-17 11:15                       ` [PATCH 05/49] spi: davinci: remove unnecessary typecast Sergei Shtylyov
     [not found]                         ` <4CE3B93A.7090408-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2010-11-17 11:35                           ` Nori, Sekhar
2010-11-17 15:24   ` [PATCH 00/49] spi: davinci: re-write existing driver Grant Likely
     [not found]     ` <20101117152426.GA5757-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-11-18  6:53       ` Nori, Sekhar
     [not found]         ` <B85A65D85D7EB246BE421B3FB0FBB5930247388244-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-11-18 11:31           ` Nori, Sekhar
     [not found]             ` <B85A65D85D7EB246BE421B3FB0FBB59302473884F7-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-11-18 13:14               ` Nori, Sekhar
     [not found]                 ` <B85A65D85D7EB246BE421B3FB0FBB59302473885A3-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-12-11 15:34                   ` Michael Williamson
     [not found]                     ` <4D0399EB.6070204-wZX4cNJlHJ2sVWG7oymsAA@public.gmane.org>
2010-12-11 20:54                       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289990661-30126-20-git-send-email-nsekhar@ti.com \
    --to=nsekhar-l0cymroini0@public.gmane.org \
    --cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
    --cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).