From: Hauke Mehrtens <hauke@hauke-m.de>
To: Dilip Kota <eswara.kota@linux.intel.com>,
broonie@kernel.org, robh@kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, daniel.schwierzeck@gmail.com,
andriy.shevchenko@intel.com, cheol.yong.kim@intel.com,
chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com
Subject: Re: [PATCH 1/4] spi: lantiq: Synchronize interrupt handlers and transfers
Date: Mon, 27 Apr 2020 23:52:59 +0200 [thread overview]
Message-ID: <1536b752-13d1-128b-1393-80cf175df5e2@hauke-m.de> (raw)
In-Reply-To: <3bf88d24b9cad9f3df1da8ed65bf55c05693b0f2.1587702428.git.eswara.kota@linux.intel.com>
On 4/24/20 12:42 PM, Dilip Kota wrote:
> Synchronize tx, rx and error interrupts by registering to the
> same interrupt handler. Interrupt handler will recognize and process
> the appropriate interrupt on the basis of interrupt status register.
> Also, establish synchronization between the interrupt handler and
> transfer operation by taking the locks and registering the interrupt
> handler as thread IRQ which avoids the bottom half.
> Fixes the wrongly populated interrupt register offsets too.
>
> Fixes: 17f84b793c01 ("spi: lantiq-ssc: add support for Lantiq SSC SPI controller")
> Fixes: ad2fca0721d1 ("spi: lantiq-ssc: add LTQ_ prefix to defines")
> Signed-off-by: Dilip Kota <eswara.kota@linux.intel.com>
> ---
> drivers/spi/spi-lantiq-ssc.c | 89 ++++++++++++++++++++++----------------------
> 1 file changed, 45 insertions(+), 44 deletions(-)
>
Hi,
I tried this patch series on a TP-LINK TD-W8970 (VRX200 with SPI flash)
and the SPI controller is failing like this:
-----
[ 6.947194] printk: bootconsole [early0] disabled
[ 6.964210] spi-lantiq-ssc 1e100800.spi: Lantiq SSC SPI controller
(Rev 8, TXFS 8, RXFS 8, DMA 1)
[ 7.175188] spi-nor spi0.4: SPI transfer timed out
[ 7.178558] spi_master spi0: failed to transfer one message from queue
[ 7.185120] spi-nor spi0.4: error -145 reading JEDEC ID
[ 7.190378] spi-nor: probe of spi0.4 failed with error -2
[ 7.199729] libphy: Fixed MDIO Bus: probed
------
It already fails when applying this first patch only.
Without this patch is works like this:
-----
[ 6.939498] printk: bootconsole [early0] disabled
[ 6.954016] spi-lantiq-ssc 1e100800.spi: Lantiq SSC SPI controller
(Rev 8, TXFS 8, RXFS 8, DMA 1)
[ 6.975465] spi-nor spi0.4: s25fl064k (8192 Kbytes)
[ 6.979066] 4 fixed-partitions partitions found on MTD device spi0.4
[ 6.985338] Creating 4 MTD partitions on "spi0.4":
[ 6.990127] 0x000000000000-0x000000020000 : "u-boot"
[ 6.997422] 0x000000020000-0x0000007c0000 : "firmware"
[ 7.212304] random: crng init done
[ 8.796128] 2 tplink-fw partitions found on MTD device firmware
[ 8.800674] 0x000000020000-0x00000027878f : "kernel"
[ 8.807776] 0x000000278790-0x0000007c0000 : "rootfs"
[ 8.813611] mtd: device 3 (rootfs) set to be root filesystem
[ 8.818268] 1 squashfs-split partitions found on MTD device rootfs
[ 8.824123] 0x000000590000-0x0000007c0000 : "rootfs_data"
[ 8.831772] 0x0000007c0000-0x0000007d0000 : "config"
[ 8.837785] 0x0000007d0000-0x000000800000 : "boardconfig"
[ 8.848193] libphy: Fixed MDIO Bus: probed
------
This was done by applying your patches on top of kernel 5.4.35 and
adding this: "spi: lantiq-ssc: Use devm_platform_ioremap_resource() in
lantiq_ssc_probe()" in OpenWrt master.
Hauke
next prev parent reply other threads:[~2020-04-27 21:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 10:42 [PATCH 0/4] spi: lantiq: Synchronize interrupts, transfers and add new features Dilip Kota
2020-04-24 10:42 ` [PATCH 1/4] spi: lantiq: Synchronize interrupt handlers and transfers Dilip Kota
2020-04-24 11:25 ` Mark Brown
2020-04-27 6:01 ` Dilip Kota
2020-04-27 13:45 ` Mark Brown
2020-04-28 5:39 ` Dilip Kota
2020-04-28 10:00 ` Mark Brown
2020-04-29 7:20 ` Dilip Kota
2020-04-29 12:27 ` Mark Brown
2020-04-27 21:52 ` Hauke Mehrtens [this message]
2020-04-28 6:03 ` Dilip Kota
2020-04-28 11:10 ` Daniel Schwierzeck
2020-04-28 11:30 ` Hauke Mehrtens
2020-04-29 8:22 ` Dilip Kota
2020-04-29 8:20 ` Dilip Kota
2020-04-29 12:13 ` Mark Brown
2020-05-04 10:15 ` Dilip Kota
2020-05-05 11:23 ` Mark Brown
2020-05-06 7:40 ` Dilip Kota
2020-07-16 9:36 ` Dilip Kota
2020-04-24 10:42 ` [PATCH 2/4] spi: lantiq: Dynamic configuration of interrupts and FIFO size Dilip Kota
2020-04-24 10:42 ` [PATCH 3/4] dt-bindings: spi: Add support to Lightning Mountain SoC Dilip Kota
2020-05-11 21:22 ` Rob Herring
2020-04-24 10:42 ` [PATCH 4/4] spi: lantiq: " Dilip Kota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536b752-13d1-128b-1393-80cf175df5e2@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=cheol.yong.kim@intel.com \
--cc=chuanhua.lei@linux.intel.com \
--cc=daniel.schwierzeck@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=eswara.kota@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=qi-ming.wu@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).