From: Krzysztof Kozlowski <krzk@kernel.org>
To: Russell King <linux@armlinux.org.uk>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project
Subject: [RFC 0/4] clk/driver: platform: Fix kfree() of const memory on setting driver_override
Date: Mon, 18 Feb 2019 11:15:56 +0100 [thread overview]
Message-ID: <1550484960-2392-1-git-send-email-krzk@kernel.org> (raw)
Hi,
The problem
===========
Several device types (platform, amba, spi etc.) provide a driver_override
field. On sysfs store or during device removal, they kfree() the
existing value.
However the users are unaware of this and set the driver_override like:
pdev->driver_override = "exynos5-subcmu";
which obviously leads to error.
Solution
========
I provided simple helper for platform device. If this approach is
acceptable, I can convert also other buses, like AMBA, SPI.
Dependencies and pick up order
==============================
Patch 1: please pick it as is through clock tree
Patch 3: Depends on patch 1 (merge conflict) and 2.
Patch 4: Depends on patch 2.
Best regards,
Krzysztof
Krzysztof Kozlowski (4):
clk: samsung: exynos5: Fix possible NULL pointer exception on
platform_device_alloc() failure
driver: platform: Provide helper for safer setting of driver_override
clk: samsung: exynos5: Fix kfree() of const memory on setting
driver_override
slimbus: ngd: Fix kfree() of const memory on setting driver_override
drivers/base/platform.c | 63 ++++++++++++++++++++++----------
drivers/clk/samsung/clk-exynos5-subcmu.c | 12 ++++--
drivers/slimbus/qcom-ngd-ctrl.c | 2 +-
include/linux/platform_device.h | 9 ++++-
4 files changed, 61 insertions(+), 25 deletions(-)
--
2.7.4
next reply other threads:[~2019-02-18 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 10:15 Krzysztof Kozlowski [this message]
2019-02-18 10:15 ` [RFC 1/4] clk: samsung: exynos5: Fix possible NULL pointer exception on platform_device_alloc() failure Krzysztof Kozlowski
2019-02-18 10:15 ` [RFC 2/4] driver: platform: Provide helper for safer setting of driver_override Krzysztof Kozlowski
2019-02-18 10:15 ` [RFC 3/4] clk: samsung: exynos5: Fix kfree() of const memory on setting driver_override Krzysztof Kozlowski
2019-02-18 10:16 ` [RFC 4/4] slimbus: ngd: " Krzysztof Kozlowski
2019-02-18 10:40 ` [RFC 0/4] clk/driver: platform: " Geert Uytterhoeven
2019-02-18 11:14 ` Krzysztof Kozlowski
2019-02-20 22:01 ` Stephen Boyd
2019-02-21 11:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550484960-2392-1-git-send-email-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project \
--cc=andy.gross@linaro.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=rafael@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).