From: Stephen Boyd <sboyd@kernel.org>
To: Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org
Cc: linux-clk@vger.kernel.org, linux-usb@vger.kernel.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 5/5] dt-bindings: Fix incorrect 'reg' property sizes
Date: Tue, 12 May 2020 14:46:16 -0700 [thread overview]
Message-ID: <158931997603.215346.13048447179585746005@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200512204543.22090-5-robh@kernel.org>
Quoting Rob Herring (2020-05-12 13:45:43)
> The examples template is a 'simple-bus' with a size of 1 cell for
> #address-cells and #size-cells. The schema was only checking the entries
> had between 2 and 4 cells which really only errors on I2C or SPI type
> devices with a single cell.
>
> The easiest fix in most cases is to change the 'reg' property to for 1 cell
> address and size. In some cases with child devices having 2 cells, that
> doesn't make sense so a bus node is needed.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org> # clk
next prev parent reply other threads:[~2020-05-12 21:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 20:45 [PATCH 1/5] spi: dt-bindings: sifive: Add missing 2nd register region Rob Herring
2020-05-12 20:45 ` [PATCH 2/5] dt-bindings: usb: ehci: " Rob Herring
2020-05-13 12:05 ` Greg Kroah-Hartman
2020-05-12 20:45 ` [PATCH 3/5] dt-bindings: ufs: ti: Fix address properties handling Rob Herring
2020-05-13 7:49 ` Vignesh Raghavendra
2020-05-12 20:45 ` [PATCH 4/5] dt-bindings: ufs: ti: Add missing 'additionalProperties: false' Rob Herring
2020-05-13 7:49 ` Vignesh Raghavendra
2020-05-12 20:45 ` [PATCH 5/5] dt-bindings: Fix incorrect 'reg' property sizes Rob Herring
2020-05-12 21:46 ` Stephen Boyd [this message]
2020-05-13 7:04 ` Geert Uytterhoeven
2020-05-13 12:10 ` [PATCH 1/5] spi: dt-bindings: sifive: Add missing 2nd register region Mark Brown
2020-05-13 13:02 ` Rob Herring
2020-05-13 14:03 ` Mark Brown
2020-05-13 21:22 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158931997603.215346.13048447179585746005@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).