Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] spi: atmel: Exposing effective spi speed
@ 2020-09-21  7:10 Thomas Kopp
  2020-10-01  6:50 ` Thomas.Kopp
  2020-10-01 22:47 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Kopp @ 2020-09-21  7:10 UTC (permalink / raw)
  To: linux-spi; +Cc: thomas.kopp, tudor.ambarus

This patch implements the reporting of the effectively used speed_hz for
the transfer by setting xfer->effective_speed_hz.

See the following patch, which adds this feature to the SPI core for more
information:
commit 5d7e2b5ed585 ("spi: core: allow reporting the effectivly used speed_hz for a transfer")

Signed-off-by: Thomas Kopp <thomas.kopp@microchip.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 drivers/spi/spi-atmel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 2cfe6253a784..799229bc34e1 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -859,6 +859,7 @@ static int atmel_spi_set_xfer_speed(struct atmel_spi *as,
 	csr = spi_readl(as, CSR0 + 4 * chip_select);
 	csr = SPI_BFINS(SCBR, scbr, csr);
 	spi_writel(as, CSR0 + 4 * chip_select, csr);
+	xfer->effective_speed_hz = bus_hz / scbr;
 
 	return 0;
 }
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v2] spi: atmel: Exposing effective spi speed
  2020-09-21  7:10 [PATCH v2] spi: atmel: Exposing effective spi speed Thomas Kopp
@ 2020-10-01  6:50 ` Thomas.Kopp
  2020-10-01 16:29   ` Mark Brown
  2020-10-01 22:47 ` Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas.Kopp @ 2020-10-01  6:50 UTC (permalink / raw)
  To: broonie; +Cc: Tudor.Ambarus, linux-spi

> This patch implements the reporting of the effectively used speed_hz for
> the transfer by setting xfer->effective_speed_hz.
> 
> See the following patch, which adds this feature to the SPI core for more
> information:
> commit 5d7e2b5ed585 ("spi: core: allow reporting the effectivly used
> speed_hz for a transfer")
> 
> Signed-off-by: Thomas Kopp <thomas.kopp@microchip.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
>  drivers/spi/spi-atmel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 2cfe6253a784..799229bc34e1 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -859,6 +859,7 @@ static int atmel_spi_set_xfer_speed(struct
> atmel_spi *as,
>  	csr = spi_readl(as, CSR0 + 4 * chip_select);
>  	csr = SPI_BFINS(SCBR, scbr, csr);
>  	spi_writel(as, CSR0 + 4 * chip_select, csr);
> +	xfer->effective_speed_hz = bus_hz / scbr;
> 
>  	return 0;
>  }
> --
> 2.25.1

Hi Mark,

I realized I only sent this to the list, not to you on to/cc. Can you consider 
pulling this please?

Thanks,
Thomas

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] spi: atmel: Exposing effective spi speed
  2020-10-01  6:50 ` Thomas.Kopp
@ 2020-10-01 16:29   ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2020-10-01 16:29 UTC (permalink / raw)
  To: Thomas.Kopp; +Cc: Tudor.Ambarus, linux-spi


[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

On Thu, Oct 01, 2020 at 06:50:08AM +0000, Thomas.Kopp@microchip.com wrote:

> I realized I only sent this to the list, not to you on to/cc. Can you consider 
> pulling this please?

In cases like this please just resend the patch so people have it in
their inbox, people's workflows tend to be based around handling things
in their inboxes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] spi: atmel: Exposing effective spi speed
  2020-09-21  7:10 [PATCH v2] spi: atmel: Exposing effective spi speed Thomas Kopp
  2020-10-01  6:50 ` Thomas.Kopp
@ 2020-10-01 22:47 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2020-10-01 22:47 UTC (permalink / raw)
  To: linux-spi, Thomas Kopp; +Cc: tudor.ambarus

On Mon, 21 Sep 2020 09:10:36 +0200, Thomas Kopp wrote:
> This patch implements the reporting of the effectively used speed_hz for
> the transfer by setting xfer->effective_speed_hz.
> 
> See the following patch, which adds this feature to the SPI core for more
> information:
> commit 5d7e2b5ed585 ("spi: core: allow reporting the effectivly used speed_hz for a transfer")

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: atmel: Exposing effective spi speed
      commit: 23f370c748580643d17b5e064478b89cba3fdc78

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21  7:10 [PATCH v2] spi: atmel: Exposing effective spi speed Thomas Kopp
2020-10-01  6:50 ` Thomas.Kopp
2020-10-01 16:29   ` Mark Brown
2020-10-01 22:47 ` Mark Brown

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git