From: "Heiko Stübner" <heiko@sntech.de>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: broonie@kernel.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] spi: rockchip: Fix error in SPI slave pio read
Date: Wed, 22 Jul 2020 09:58:54 +0200 [thread overview]
Message-ID: <1605191.QXBl1gRHXa@diego> (raw)
In-Reply-To: <20200722065257.17943-3-jon.lin@rock-chips.com>
Hi Jon,
Am Mittwoch, 22. Juli 2020, 08:52:57 CEST schrieb Jon Lin:
> The RXFLR is possible larger than rx_left in Rockchip SPI, fix it.
>
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
> ---
> drivers/spi/spi-rockchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
> index a451dacab5cf..1f5e613b67d9 100644
> --- a/drivers/spi/spi-rockchip.c
> +++ b/drivers/spi/spi-rockchip.c
> @@ -291,7 +291,7 @@ static void rockchip_spi_pio_writer(struct rockchip_spi *rs)
> static void rockchip_spi_pio_reader(struct rockchip_spi *rs)
> {
> u32 words = readl_relaxed(rs->regs + ROCKCHIP_SPI_RXFLR);
> - u32 rx_left = rs->rx_left - words;
> + u32 rx_left = rs->rx_left > words ? rs->rx_left - words : 0;
I guess for future readability of the code braces might be nice, like
u32 rx_left = (rs->rx_left > words) ? rs->rx_left - words : 0;
But I stumbled onto (and fixed similarly) that issue yesterday as well, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Heiko
prev parent reply other threads:[~2020-07-22 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 6:52 [PATCH v1 1/3] spi: rockchip: Config spi rx dma burst size depend on xfer length Jon Lin
2020-07-22 6:52 ` [PATCH v1 2/3] spi: rockchip: Support 64-location deep FIFOs Jon Lin
2020-07-22 6:52 ` [PATCH v1 3/3] spi: rockchip: Fix error in SPI slave pio read Jon Lin
2020-07-22 7:58 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605191.QXBl1gRHXa@diego \
--to=heiko@sntech.de \
--cc=broonie@kernel.org \
--cc=jon.lin@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).