Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] linux/spi: Remove repeated struct declaration
@ 2021-04-01  6:59 Wan Jiabing
  2021-04-01 10:46 ` Mark Brown
  2021-04-01 16:15 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2021-04-01  6:59 UTC (permalink / raw)
  To: Mark Brown, linux-spi, linux-kernel; +Cc: kael_w, Wan Jiabing

struct spi_transfer is declared twice. One is declared at 24th line.
The blew one is not needed though. Remove the duplicate.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 include/linux/spi/spi.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index 592897fa4f03..c345392a11ee 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -247,7 +247,6 @@ static inline void *spi_get_drvdata(struct spi_device *spi)
 }
 
 struct spi_message;
-struct spi_transfer;
 
 /**
  * struct spi_driver - Host side "protocol" driver
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] linux/spi: Remove repeated struct declaration
  2021-04-01  6:59 [PATCH] linux/spi: Remove repeated struct declaration Wan Jiabing
@ 2021-04-01 10:46 ` Mark Brown
  2021-04-01 16:15 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-04-01 10:46 UTC (permalink / raw)
  To: Wan Jiabing; +Cc: linux-spi, linux-kernel, kael_w


[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

On Thu, Apr 01, 2021 at 02:59:04PM +0800, Wan Jiabing wrote:
> struct spi_transfer is declared twice. One is declared at 24th line.
> The blew one is not needed though. Remove the duplicate.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] linux/spi: Remove repeated struct declaration
  2021-04-01  6:59 [PATCH] linux/spi: Remove repeated struct declaration Wan Jiabing
  2021-04-01 10:46 ` Mark Brown
@ 2021-04-01 16:15 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-04-01 16:15 UTC (permalink / raw)
  To: Wan Jiabing, linux-kernel, linux-spi; +Cc: Mark Brown, kael_w

On Thu, 1 Apr 2021 14:59:04 +0800, Wan Jiabing wrote:
> struct spi_transfer is declared twice. One is declared at 24th line.
> The blew one is not needed though. Remove the duplicate.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] linux/spi: Remove repeated struct declaration
      commit: d6644a1c2e17febf261fd692bb32271e5779bbd2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01  6:59 [PATCH] linux/spi: Remove repeated struct declaration Wan Jiabing
2021-04-01 10:46 ` Mark Brown
2021-04-01 16:15 ` Mark Brown

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git