Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH -next] spi: qup: fix PM reference leak in spi_qup_remove()
  2021-04-09  9:54 [PATCH -next] spi: qup: fix PM reference leak in spi_qup_remove() Wang Li
@ 2021-04-09  9:49 ` Manivannan Sadhasivam
  2021-04-09 16:22 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2021-04-09  9:49 UTC (permalink / raw)
  To: Wang Li
  Cc: broonie, bjorn.andersson, agross, linux-arm-msm, linux-spi, linux-kernel

On Fri, Apr 09, 2021 at 09:54:58AM +0000, Wang Li wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Li <wangli74@huawei.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  drivers/spi/spi-qup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
> index 8dcb2e70735c..d39dec6d1c91 100644
> --- a/drivers/spi/spi-qup.c
> +++ b/drivers/spi/spi-qup.c
> @@ -1263,7 +1263,7 @@ static int spi_qup_remove(struct platform_device *pdev)
>  	struct spi_qup *controller = spi_master_get_devdata(master);
>  	int ret;
>  
> -	ret = pm_runtime_get_sync(&pdev->dev);
> +	ret = pm_runtime_resume_and_get(&pdev->dev);
>  	if (ret < 0)
>  		return ret;
>  
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH -next] spi: qup: fix PM reference leak in spi_qup_remove()
@ 2021-04-09  9:54 Wang Li
  2021-04-09  9:49 ` Manivannan Sadhasivam
  2021-04-09 16:22 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Wang Li @ 2021-04-09  9:54 UTC (permalink / raw)
  To: broonie, bjorn.andersson, agross
  Cc: linux-arm-msm, linux-spi, linux-kernel, Wang Li

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Li <wangli74@huawei.com>
---
 drivers/spi/spi-qup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 8dcb2e70735c..d39dec6d1c91 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -1263,7 +1263,7 @@ static int spi_qup_remove(struct platform_device *pdev)
 	struct spi_qup *controller = spi_master_get_devdata(master);
 	int ret;
 
-	ret = pm_runtime_get_sync(&pdev->dev);
+	ret = pm_runtime_resume_and_get(&pdev->dev);
 	if (ret < 0)
 		return ret;
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] spi: qup: fix PM reference leak in spi_qup_remove()
  2021-04-09  9:54 [PATCH -next] spi: qup: fix PM reference leak in spi_qup_remove() Wang Li
  2021-04-09  9:49 ` Manivannan Sadhasivam
@ 2021-04-09 16:22 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-04-09 16:22 UTC (permalink / raw)
  To: bjorn.andersson, agross, Wang Li
  Cc: Mark Brown, linux-arm-msm, linux-kernel, linux-spi

On Fri, 9 Apr 2021 09:54:58 +0000, Wang Li wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: qup: fix PM reference leak in spi_qup_remove()
      commit: cec77e0a249892ceb10061bf17b63f9fb111d870

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09  9:54 [PATCH -next] spi: qup: fix PM reference leak in spi_qup_remove() Wang Li
2021-04-09  9:49 ` Manivannan Sadhasivam
2021-04-09 16:22 ` Mark Brown

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git