From: <Tudor.Ambarus@microchip.com>
To: <vigneshr@ti.com>
Cc: <broonie@kernel.org>, <bbrezillon@kernel.org>,
<vadivel.muruganx.ramuthevar@linux.intel.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <simon.k.r.goldschmidt@gmail.com>,
<dinguyen@kernel.org>, <marex@denx.de>
Subject: Re: [PATCH v2 1/6] mtd: spi-nor: cadence-quadspi: Make driver independent of flash geometry
Date: Thu, 28 May 2020 11:41:52 +0000 [thread overview]
Message-ID: <1873244.LXWL5g5pfh@192.168.0.120> (raw)
In-Reply-To: <20200526093604.11846-2-vigneshr@ti.com>
On Tuesday, May 26, 2020 12:35:59 PM EEST Vignesh Raghavendra wrote:
> Drop configuration of Flash size, erase size and page size
> configuration. Flash size is needed only if using AHB decoder (BIT 23 of
> CONFIG_REG) which is not used by the driver.
> Erase size and page size are needed if IP is configured to send WREN
> automatically. But since SPI NOR layer takes care of sending WREN, there
> is no need to configure these fields either.
>
> Therefore drop these in preparation to move the driver to spi-mem
> framework where flash geometry is not visible to controller driver.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> .../mtd/spi-nor/controllers/cadence-quadspi.c | 36 +------------------
> 1 file changed, 1 insertion(+), 35 deletions(-)
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
next prev parent reply other threads:[~2020-05-28 11:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 9:35 [PATCH v2 0/6] mtd: spi-nor: Move cadence-qaudspi to spi-mem framework Vignesh Raghavendra
2020-05-26 9:35 ` [PATCH v2 1/6] mtd: spi-nor: cadence-quadspi: Make driver independent of flash geometry Vignesh Raghavendra
2020-05-28 11:41 ` Tudor.Ambarus [this message]
2020-05-26 9:36 ` [PATCH v2 2/6] mtd: spi-nor: cadence-quadspi: Provide a way to disable DAC mode Vignesh Raghavendra
2020-05-28 18:41 ` Tudor.Ambarus
2020-05-26 9:36 ` [PATCH v2 3/6] mtd: spi-nor: cadence-quadspi: Don't initialize rx_dma_complete on failure Vignesh Raghavendra
2020-05-28 18:42 ` Tudor.Ambarus
2020-05-26 9:36 ` [PATCH v2 4/6] mtd: spi-nor: cadence-quadspi: Fix error path on failure to acquire reset lines Vignesh Raghavendra
2020-05-28 18:46 ` Tudor.Ambarus
2020-05-26 9:36 ` [PATCH v2 5/6] mtd: spi-nor: Convert cadence-quadspi to use spi-mem framework Vignesh Raghavendra
2020-05-30 13:50 ` Tudor.Ambarus
2020-06-01 4:56 ` Vignesh Raghavendra
2020-05-26 9:36 ` [PATCH v2 6/6] spi: Move cadence-quadspi driver to drivers/spi/ Vignesh Raghavendra
2020-05-27 20:58 ` kbuild test robot
2020-05-28 9:54 ` Vignesh Raghavendra
2020-05-30 14:03 ` Tudor.Ambarus
2020-06-19 13:28 ` [PATCH v2 0/6] mtd: spi-nor: Move cadence-qaudspi to spi-mem framework Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1873244.LXWL5g5pfh@192.168.0.120 \
--to=tudor.ambarus@microchip.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
--cc=simon.k.r.goldschmidt@gmail.com \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).