From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 2.6.22-rc3-git] SPI dynamic busid generation bugfix Date: Fri, 1 Jun 2007 16:53:01 -0700 Message-ID: <20070601165301.6896b299.akpm@linux-foundation.org> References: <200706011612.19766.david-b@pacbell.net> <20070601163339.482e2327.akpm@linux-foundation.org> <200706011646.12340.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: David Brownell Return-path: In-Reply-To: <200706011646.12340.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, 1 Jun 2007 16:46:12 -0700 David Brownell wrote: > On Friday 01 June 2007, Andrew Morton wrote: > > > > Is this going to underflow then malfunction after 32k modprobe+rmmods? > > Yes. A better fix will be needed, for the crazy people amongst us. > Dynamic busids are quite uncommon though, so that's not pressing. lib/idr.c can be used for this. There are patches in Greg's driver tree which make it better-suited. The give-me-a-unique-integer thing is so common that we really should have a wrapper around idr which does just that. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/