From: David Brownell <david-b@pacbell.net>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: spi-devel-general@lists.sourceforge.net, sshtylyov@ru.mvista.com,
linux-mips@linux-mips.org, ralf@linux-mips.org,
mlachwani@mvista.com
Subject: Re: [spi-devel-general] [PATCH] TXx9 SPI controller driver
Date: Sat, 23 Jun 2007 09:09:51 -0700 [thread overview]
Message-ID: <200706230909.52037.david-b@pacbell.net> (raw)
In-Reply-To: <20070624.004159.07644824.anemo@mba.ocn.ne.jp>
On Saturday 23 June 2007, Atsushi Nemoto wrote:
> Thank you for excellent review! I'll look at each comments surely
> will update the driver but it may take a few days.
That's fine.
> For now, I'm quite sure your patch is OK for me except for one thing:
>
> > + * spi_tx99.c - TXx9 SPI controller driver.
>
> Name it spi_txx9.c, please ;)
Sorry, typo! ... please fix when you resubmit.
> And for mmiowb() issue, I put it just only I was not sure whether
> gpio_set_value() guarantee I/O barrier. Now I see i2c-gpio.c, etc. do
> not have such barriers. I will remove these barriers and fix platform
> gpio codes.
I don't think this is a case where there'd be a benefit to
allowing non-barriered implementations, and thus requiring
all portable code to include platform-neutral I/O barriers.
I don't know that such neutral primitives actually exist...
I'll update the GPIO docs to make that clear, unless you
have some strong argument to the contrary.
- Dave
next prev parent reply other threads:[~2007-06-23 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070622.232111.36926005.anemo@mba.ocn.ne.jp>
[not found] ` <20070622.232111.36926005.anemo-7JcRY8pycbNHfZP73Gtkiw@public.gmane.org>
2007-06-22 18:03 ` [PATCH] TXx9 SPI controller driver David Brownell
[not found] ` <200706221103.19761.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-06-22 18:51 ` David Brownell
[not found] ` <200706221151.24959.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-06-23 15:41 ` Atsushi Nemoto
2007-06-23 16:09 ` David Brownell [this message]
[not found] ` <200706230909.52037.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-06-24 15:56 ` Atsushi Nemoto
2007-06-24 16:15 ` Atsushi Nemoto
2007-06-25 16:12 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706230909.52037.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=mlachwani@mvista.com \
--cc=ralf@linux-mips.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).