Re: Protocol driver probe function never invoked

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Tuesday 24 July 2007, David Brownell wrote:
> I want to be sure I understand this correctly.  You're saying that
> the call to spi_setup() inside of spi_new_device() failed silently?
> And thus the scan_boardinfo() failed?
> 
> If so, I'm thinking the following patch would help ... right?

Helps to run GCC *first* ...

--- g26.orig/drivers/spi/spi.c	2007-07-24 06:31:44.000000000 -0700
+++ g26/drivers/spi/spi.c	2007-07-24 06:31:40.000000000 -0700
@@ -327,7 +327,12 @@ static void scan_boardinfo(struct spi_ma
 		for (n = bi->n_board_info; n > 0; n--, chip++) {
 			if (chip->bus_num != master->bus_num)
 				continue;
-			(void) spi_new_device(master, chip);
+			if (spi_new_device(master, chip) == NULL)
+				dev_err(master->cdev.dev,
+					"can't create spi_device for "
+					"chipselect %d, modalias %s\n",
+					chip->chip_select,
+					chip->modalias);
 		}
 	}
 	mutex_unlock(&board_lock);


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/