From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Ossman Subject: Re: [patch 2.6.22-git5 1/4] MMC headers learn about SPI Date: Thu, 26 Jul 2007 20:05:25 +0200 Message-ID: <20070726200525.6a5b7d72@poseidon.drzeus.cx> References: <200707141504.51950.david-b@pacbell.net> <200707141506.00262.david-b@pacbell.net> <20070726183150.024930aa@poseidon.drzeus.cx> <200707260955.22967.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Hans-Peter Nilsson , Mikael Starvik , Mike Lavender , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: David Brownell Return-path: In-Reply-To: <200707260955.22967.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thu, 26 Jul 2007 09:55:22 -0700 David Brownell wrote: > > As explained in the comment: this reduces the padding. > The previous way needed one word per bitfield; this way > they all fit into the same word... > Ah, didn't realize that. I blame the effect two weeks of vacation has on the brain. :) Perhaps shuffling them all to the end (before private) so that it is more clear that they are grouped because of padding issues? > > I'm not sure what you mean here, but then my first cup of coffee is > still trying to do its work. Are you saying you want me to > > - increase the padding again? > - define an MMC_RSP_SPI_BUSY, and use that? > > The former would bother me a bit, but I could understand if you wanted > it to be in a different patch. The latter is no problem at all. > Well, both initially. But padding is a relevant concern, so I'm content with the latter. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/