* [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on any processors with QUICC Engine [not found] ` <20071005174015.GA11016-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> @ 2007-10-05 17:46 ` Anton Vorontsov 0 siblings, 0 replies; 2+ messages in thread From: Anton Vorontsov @ 2007-10-05 17:46 UTC (permalink / raw) To: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f Currently, all QE SPI controllers are almost the same comparing to MPC83xx's, thus let's use that driver for them. Tested to work on MPC85xx in loopback mode. Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> --- This is respin. Hope this time it will get ack from the PowerPC team. drivers/spi/Kconfig | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index b915711..a77ede5 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -124,16 +124,17 @@ config SPI_MPC52xx_PSC Controller in master SPI mode. config SPI_MPC83xx - tristate "Freescale MPC83xx SPI controller" - depends on SPI_MASTER && PPC_83xx && EXPERIMENTAL + tristate "Freescale MPC83xx/QUICC Engine SPI controller" + depends on SPI_MASTER && (PPC_83xx || QUICC_ENGINE) && EXPERIMENTAL select SPI_BITBANG help - This enables using the Freescale MPC83xx SPI controller in master - mode. + This enables using the Freescale MPC83xx and QUICC Engine SPI + controllers in master mode. Note, this driver uniquely supports the SPI controller on the MPC83xx - family of PowerPC processors. The MPC83xx uses a simple set of shift - registers for data (opposed to the CPM based descriptor model). + family of PowerPC processors, plus processors with QUICC Engine + technology. This driver uses a simple set of shift registers for data + (opposed to the CPM based descriptor model). config SPI_OMAP_UWIRE tristate "OMAP1 MicroWire" -- 1.5.0.6 ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ ^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <20070925143126.GA30013@localhost.localdomain>]
* [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on MPC85xx @ 2007-09-25 14:35 ` Anton Vorontsov 2007-09-25 15:04 ` Kumar Gala 0 siblings, 1 reply; 2+ messages in thread From: Anton Vorontsov @ 2007-09-25 14:35 UTC (permalink / raw) To: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f MPC85xx's QE SPI controller is almost the same comparing to MPC83xx. Thus lets use that driver. Tested to work in loopback mode. Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> --- drivers/spi/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index b915711..14f0d0d 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -125,7 +125,7 @@ config SPI_MPC52xx_PSC config SPI_MPC83xx tristate "Freescale MPC83xx SPI controller" - depends on SPI_MASTER && PPC_83xx && EXPERIMENTAL + depends on SPI_MASTER && (PPC_83xx || PPC_85xx) && EXPERIMENTAL select SPI_BITBANG help This enables using the Freescale MPC83xx SPI controller in master -- 1.5.0.6 ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on MPC85xx @ 2007-09-25 15:04 ` Kumar Gala 2007-09-25 15:18 ` Anton Vorontsov 0 siblings, 1 reply; 2+ messages in thread From: Kumar Gala @ 2007-09-25 15:04 UTC (permalink / raw) To: Anton Vorontsov Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f On Sep 25, 2007, at 9:35 AM, Anton Vorontsov wrote: > MPC85xx's QE SPI controller is almost the same comparing to MPC83xx. > Thus lets use that driver. Tested to work in loopback mode. > > Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> > --- > drivers/spi/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index b915711..14f0d0d 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -125,7 +125,7 @@ config SPI_MPC52xx_PSC > > config SPI_MPC83xx > tristate "Freescale MPC83xx SPI controller" > - depends on SPI_MASTER && PPC_83xx && EXPERIMENTAL > + depends on SPI_MASTER && (PPC_83xx || PPC_85xx) && EXPERIMENTAL > select SPI_BITBANG > help > This enables using the Freescale MPC83xx SPI controller in master Should that really be just PPC_83xx || QUICC_ENGINE? - k ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on MPC85xx @ 2007-09-25 15:18 ` Anton Vorontsov 2007-09-25 16:58 ` David Brownell 0 siblings, 1 reply; 2+ messages in thread From: Anton Vorontsov @ 2007-09-25 15:18 UTC (permalink / raw) To: Kumar Gala Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f On Tue, Sep 25, 2007 at 10:04:41AM -0500, Kumar Gala wrote: > > On Sep 25, 2007, at 9:35 AM, Anton Vorontsov wrote: > >> MPC85xx's QE SPI controller is almost the same comparing to MPC83xx. >> Thus lets use that driver. Tested to work in loopback mode. >> >> Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> >> --- >> drivers/spi/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig >> index b915711..14f0d0d 100644 >> --- a/drivers/spi/Kconfig >> +++ b/drivers/spi/Kconfig >> @@ -125,7 +125,7 @@ config SPI_MPC52xx_PSC >> >> config SPI_MPC83xx >> tristate "Freescale MPC83xx SPI controller" >> - depends on SPI_MASTER && PPC_83xx && EXPERIMENTAL >> + depends on SPI_MASTER && (PPC_83xx || PPC_85xx) && EXPERIMENTAL >> select SPI_BITBANG >> help >> This enables using the Freescale MPC83xx SPI controller in master > > Should that really be just PPC_83xx || QUICC_ENGINE? Well, I thought about that. By now I'm unsure if every QE implementation will be compatible with further ones. So far I've tested this driver on MPC8323 and MPC8568. If we'll see more and more compatible QE SPI controllers, of course we may just do || QUICC_ENGINE. PPC_83xx || PPC_85xx PPC_83xx || QUICC_ENGINE Today first option saves us four bytes. ;-) ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on MPC85xx @ 2007-09-25 16:58 ` David Brownell 2007-09-26 4:00 ` Kumar Gala 0 siblings, 1 reply; 2+ messages in thread From: David Brownell @ 2007-09-25 16:58 UTC (permalink / raw) To: galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r, avorontsov-hkdhdckH98+B+jHODAdFcQ Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A > >> - depends on SPI_MASTER && PPC_83xx && EXPERIMENTAL > >> + depends on SPI_MASTER && (PPC_83xx || PPC_85xx) && EXPERIMENTAL > > > > Should that really be just PPC_83xx || QUICC_ENGINE? > > Well, I thought about that. By now I'm unsure if every QE > implementation will be compatible with further ones. How many other QE implementations exist? Is that sort of gratuitous breakage something Freescale makes a habit of? > So far > I've tested this driver on MPC8323 and MPC8568. If we'll see > more and more compatible QE SPI controllers, of course we > may just do || QUICC_ENGINE. > > PPC_83xx || PPC_85xx > PPC_83xx || QUICC_ENGINE > > Today first option saves us four bytes. ;-) It'd be good if someone would look at the relevant docs. I'll wait for a PPC signoff before I forward this for merge with SPI stuff... _ Dave ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on MPC85xx @ 2007-09-26 4:00 ` Kumar Gala [not found] ` <7881139C-EEF1-41DC-AB0F-115632E892B8-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Kumar Gala @ 2007-09-26 4:00 UTC (permalink / raw) To: David Brownell Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A On Sep 25, 2007, at 11:58 AM, David Brownell wrote: >>>> - depends on SPI_MASTER && PPC_83xx && EXPERIMENTAL >>>> + depends on SPI_MASTER && (PPC_83xx || PPC_85xx) && EXPERIMENTAL >>> >>> Should that really be just PPC_83xx || QUICC_ENGINE? >> >> Well, I thought about that. By now I'm unsure if every QE >> implementation will be compatible with further ones. > > How many other QE implementations exist? Is that sort of > gratuitous breakage something Freescale makes a habit of? We try not to, but HW people are know to do evil things to keep us software guys employed. >> So far >> I've tested this driver on MPC8323 and MPC8568. If we'll see >> more and more compatible QE SPI controllers, of course we >> may just do || QUICC_ENGINE. >> >> PPC_83xx || PPC_85xx >> PPC_83xx || QUICC_ENGINE >> >> Today first option saves us four bytes. ;-) > > It'd be good if someone would look at the relevant docs. > > I'll wait for a PPC signoff before I forward this for > merge with SPI stuff... I'm still in favor of making it PPC_83xx || QUICC_ENGINE. So if when we have 87xx with QUICC_ENGINE we don't have to tweak it again, but its a minor thing. - k ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <7881139C-EEF1-41DC-AB0F-115632E892B8-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>]
* [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on any processors with QUICC Engine [not found] ` <7881139C-EEF1-41DC-AB0F-115632E892B8-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> @ 2007-09-26 13:15 ` Anton Vorontsov 0 siblings, 0 replies; 2+ messages in thread From: Anton Vorontsov @ 2007-09-26 13:15 UTC (permalink / raw) To: Kumar Gala Cc: David Brownell, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A On Tue, Sep 25, 2007 at 11:00:38PM -0500, Kumar Gala wrote: > I'm still in favor of making it PPC_83xx || QUICC_ENGINE. Submitting... ;-) - - - - From: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> Subject: [POWERPC][SPI] spi_mpc83xx: allow use on any processors with QUICC Engine Currently, all QE SPI controllers are almost the same comparing to MPC83xx's, thus let's use that driver for them. Tested to work on MPC85xx in loopback mode. Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> --- drivers/spi/Kconfig | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index b915711..a77ede5 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -124,16 +124,17 @@ config SPI_MPC52xx_PSC Controller in master SPI mode. config SPI_MPC83xx - tristate "Freescale MPC83xx SPI controller" - depends on SPI_MASTER && PPC_83xx && EXPERIMENTAL + tristate "Freescale MPC83xx/QUICC Engine SPI controller" + depends on SPI_MASTER && (PPC_83xx || QUICC_ENGINE) && EXPERIMENTAL select SPI_BITBANG help - This enables using the Freescale MPC83xx SPI controller in master - mode. + This enables using the Freescale MPC83xx and QUICC Engine SPI + controllers in master mode. Note, this driver uniquely supports the SPI controller on the MPC83xx - family of PowerPC processors. The MPC83xx uses a simple set of shift - registers for data (opposed to the CPM based descriptor model). + family of PowerPC processors, plus processors with QUICC Engine + technology. This driver uses a simple set of shift registers for data + (opposed to the CPM based descriptor model). config SPI_OMAP_UWIRE tristate "OMAP1 MicroWire" -- 1.5.0.6 ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-05 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20071005174015.GA11016@localhost.localdomain>
[not found] ` <20071005174015.GA11016-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-10-05 17:46 ` [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on any processors with QUICC Engine Anton Vorontsov
[not found] <20070925143126.GA30013@localhost.localdomain>
2007-09-25 14:35 ` [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on MPC85xx Anton Vorontsov
2007-09-25 15:04 ` Kumar Gala
2007-09-25 15:18 ` Anton Vorontsov
2007-09-25 16:58 ` David Brownell
2007-09-26 4:00 ` Kumar Gala
[not found] ` <7881139C-EEF1-41DC-AB0F-115632E892B8-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2007-09-26 13:15 ` [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on any processors with QUICC Engine Anton Vorontsov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).