From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Ossman Subject: Re: [patch 3/4 2.6.23-rc2 + mm2-git-mmc] MMC core learns about SPI Date: Sat, 27 Oct 2007 14:08:23 +0200 Message-ID: <20071027140823.5d7ec7e2@poseidon.drzeus.cx> References: <200708080906.18993.david-b@pacbell.net> <20070829092247.GA15021@pengutronix.de> <20070829165243.0236cc89@poseidon.drzeus.cx> <200708290943.59450.david-b@pacbell.net> <470A644A.8030405@gmail.com> <20071010203613.55676dba@poseidon.drzeus.cx> <20071022203428.300117e4@poseidon.drzeus.cx> <471DAB71.8000808@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Hans-Peter Nilsson , David Brownell , Mikael Starvik , Mike Lavender , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jan Nikitenko Return-path: In-Reply-To: <471DAB71.8000808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tue, 23 Oct 2007 10:06:09 +0200 Jan Nikitenko wrote: > Pierre Ossman wrote: > > Ah. I see what you mean now. The problem is in the data transfer, not a response field. So Sacha's patch was almost correct. Could you test if the included patch solves your issue? > > With your patch it works as good as with the one from Sascha. > Great. I'll send it to Linus then. (Just in case it wasn't apparent, my patch was different from Sascha's as his flipped some stuff that shouldn't) > > > > Is this really a problem that plagues you, or just something you noticed in the code? > > It is that we need to suspend as soon as possible because of power loss. > Waiting to flush all the caches does not help, because there will not be > enough time with backup power. So it's better not to start any new block > requests to safe as much backup power as possible and to avoid > interrupted block transfer. > Ah, that is a very good point. Could I bother you with having a look at how other parts of the kernel does things? Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/