From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH 00/14] Blackfin on-chip SPI controller driver updates and bug-fixing Date: Tue, 30 Oct 2007 13:24:07 -0700 Message-ID: <200710301324.07691.david-b@pacbell.net> References: <1193735885-8202-1-git-send-email-bryan.wu@analog.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bryan Wu Return-path: In-Reply-To: <1193735885-8202-1-git-send-email-bryan.wu-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tuesday 30 October 2007, Bryan Wu wrote: > - BF54x supported > - multi-port supported > - bunch of bug fixing OK, I forwarded these with some more checkpatch.pl fixes. But as I commented elsewhere, please work harder to make sure that your patch comments actually match the patches!! And also, pay closer attention to when you may be making changes that make device drivers work differently over your spi_master controller driver than anyone elses ... such platform-specific behaviors are undesirable, and when they go against specified behavior they are also bugs. - Dave ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/