From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: Ben Dooks <ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [patch 2.6.24-rc8] spi: s3c drivers shouldn't care about spi_board_info
Date: Tue, 22 Jan 2008 00:09:11 -0800 [thread overview]
Message-ID: <20080122000911.4b61af5c.akpm@linux-foundation.org> (raw)
In-Reply-To: <200801212341.07086.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
On Mon, 21 Jan 2008 23:41:06 -0800 David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:
> The two S3C SPI master drivers got merged without much review, so
> I just noticed that they're doing something that the SPI core code
> is responsible for, rather than any adapter driver: they try to
> register SPI devices.
err, but these driver predate the generic SPI core, I think?
> drivers/spi/spi_s3c24xx.c | 12 ------------
> drivers/spi/spi_s3c24xx_gpio.c | 12 ------------
> include/asm/arch/spi-gpio.h | 6 ------
> include/asm/arch/spi.h | 6 ------
argh, please don't do that.
<searches>
It looks like this is referring to include/asm-arm/arch-s3c2410/
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-01-22 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 7:41 [patch 2.6.24-rc8] spi: s3c drivers shouldn't care about spi_board_info David Brownell
[not found] ` <200801212341.07086.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-01-22 8:09 ` Andrew Morton [this message]
[not found] ` <20080122000911.4b61af5c.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-01-22 8:23 ` David Brownell
2008-02-19 10:10 ` Ben Dooks
[not found] ` <20080219101048.GA24550-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2008-02-21 2:37 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122000911.4b61af5c.akpm@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).