Re: mmc_spi.c driver

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Tuesday 29 April 2008, David Brownell wrote:
> 
> > > mmc0: error -22 whilst initialising SDIO card  
> > 
> > This is a bit odd. It shouldn't have gone down that route unless it is
> > sure it's an SDIO card it is dealing with.
> 
> I've seen that in the past, I forget why.  It may have been the
> problem with cards that didn't like to respond to certain requests
> while they're resetting ... the problem which ensures that I must
> always use the appended patch, since you didn't want to merge it.
> 

When enumerating MMC cards using SPI, don't support the "just probe"
mechanism since it doesn't always work.  Instead, always wait for the
reset to complete before issuing the next request.  (Failed on an
otherwise trusty SanDisk MMC card...)

Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
---
 drivers/mmc/core/mmc_ops.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

--- a/drivers/mmc/core/mmc_ops.c	2007-11-05 18:17:50.000000000 -0800
+++ b/drivers/mmc/core/mmc_ops.c	2007-11-05 18:24:32.000000000 -0800
@@ -114,8 +114,11 @@ int mmc_send_op_cond(struct mmc_host *ho
 		if (err)
 			break;
 
-		/* if we're just probing, do a single pass */
-		if (ocr == 0)
+		/* if we're just probing, do a single pass ... except,
+		 * accomodate cards which don't behave right until a
+		 * SPI reset completes.
+		 */
+		if (ocr == 0 && !mmc_host_is_spi(host))
 			break;
 
 		/* otherwise wait until reset completes */


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone