From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH/RFC] spi: Change modalias from a pointer to a character array Date: Wed, 21 May 2008 17:03:25 -0700 Message-ID: <200805211703.25822.david-b@pacbell.net> References: <20080509173146.2932.16141.stgit@trillian.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely Return-path: In-Reply-To: <20080509173146.2932.16141.stgit-8FIgwK2HfyId2tlXD8uQ6/kpB+XfMlBf@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Friday 09 May 2008, Grant Likely wrote: > This patch changes modalias from a 'const char *' to a fixed char array. > By copying the modalias string instead of referencing it, the dependency > on the spi_board_info structure is eliminated and an outside caller does > not need to maintain a separate spi_board_info allocation for each device. Looks fine to me. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/