From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Guennadi Liakhovetski
<g.liakhovetski-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] pxa2xx_spi.c: remove redundant initialization, spelling fix, more verbose error
Date: Wed, 4 Jun 2008 12:32:38 -0700 [thread overview]
Message-ID: <200806041232.39106.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0806041645070.32657-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
On Wednesday 04 June 2008, Guennadi Liakhovetski wrote:
> Minor fixes: remove redundant local variable initialization, fix "can not" to
> what I _think_ is a preferred spelling, output IRQ number if requesting it
> failed.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Acked-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
>
> ---
>
> Nothing urgent, just, please, queue it for 2.6.27. Thanks
>
> diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
> index 0c452c4..4cf72e9 100644
> --- a/drivers/spi/pxa2xx_spi.c
> +++ b/drivers/spi/pxa2xx_spi.c
> @@ -1342,9 +1342,9 @@ static int __init pxa2xx_spi_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct pxa2xx_spi_master *platform_info;
> struct spi_master *master;
> - struct driver_data *drv_data = NULL;
> + struct driver_data *drv_data;
> struct ssp_device *ssp;
> - int status = 0;
> + int status;
>
> platform_info = dev->platform_data;
>
> @@ -1357,7 +1357,7 @@ static int __init pxa2xx_spi_probe(struct platform_device *pdev)
> /* Allocate master with space for drv_data and null dma buffer */
> master = spi_alloc_master(dev, sizeof(struct driver_data) + 16);
> if (!master) {
> - dev_err(&pdev->dev, "can not alloc spi_master\n");
> + dev_err(&pdev->dev, "cannot alloc spi_master\n");
> ssp_free(ssp);
> return -ENOMEM;
> }
> @@ -1393,7 +1393,7 @@ static int __init pxa2xx_spi_probe(struct platform_device *pdev)
>
> status = request_irq(ssp->irq, ssp_int, 0, dev->bus_id, drv_data);
> if (status < 0) {
> - dev_err(&pdev->dev, "can not get IRQ\n");
> + dev_err(&pdev->dev, "cannot get IRQ %d\n", ssp->irq);
> goto out_error_master_alloc;
> }
>
>
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
prev parent reply other threads:[~2008-06-04 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 14:47 [PATCH] pxa2xx_spi.c: remove redundant initialization, spelling fix, more verbose error Guennadi Liakhovetski
[not found] ` <Pine.LNX.4.64.0806041645070.32657-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-06-04 19:32 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806041232.39106.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=g.liakhovetski-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).