From: Stefan Roese <sr@denx.de>
To: David Brownell <david-b@pacbell.net>
Cc: spi-devel-general@lists.sourceforge.net, linuxppc-dev@ozlabs.org
Subject: Re: [spi-devel-general] [PATCH v4] spi: Add PPC4xx SPI driver
Date: Fri, 21 Nov 2008 19:01:45 +0100 [thread overview]
Message-ID: <200811211901.45371.sr@denx.de> (raw)
In-Reply-To: <200811201941.08468.david-b@pacbell.net>
Dave,
On Friday 21 November 2008, David Brownell wrote:
> On Friday 31 October 2008, Stefan Roese wrote:
> > + dev_dbg(&spi->dev, "%s: mode %d, %u bpw, %d hz\n",
> > + __FUNCTION__, spi->mode, spi->bits_per_word,
> > + spi->max_speed_hz);
>
> Oh, and checkpatch.pl would warn about __FUNCTION__ vs __func__ ...
Thanks for the review. I'll address the issues in an updated patch next week.
Best regards,
Stefan
prev parent reply other threads:[~2008-11-21 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 11:07 [PATCH v4] spi: Add PPC4xx SPI driver Stefan Roese
[not found] ` <1225451266-23740-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
2008-11-04 13:10 ` Josh Boyer
2008-11-21 3:40 ` David Brownell
2008-11-21 3:41 ` David Brownell
2008-11-21 18:01 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811211901.45371.sr@denx.de \
--to=sr@denx.de \
--cc=david-b@pacbell.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).