From: Ben Dooks <ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
dbrownell-Rn4VEauK+AKRv+LV9MX5uv+2+P5yyue3@public.gmane.org
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [patch 3/7] spi_s3c24xx; Fix transfer setup code
Date: Thu, 13 Aug 2009 11:06:05 +0100 [thread overview]
Message-ID: <20090813100638.583297488@fluff.org> (raw)
In-Reply-To: 20090813100602.545180197@fluff.org
[-- Attachment #1: spi-fix-bitperword.patch --]
[-- Type: text/plain, Size: 1218 bytes --]
Since the changes to the bitbang driver, there is the possibility we
will be called with either the speed_hz or bpw values zero. We take
these to mean that the default values (8 bits per word, or maximum
bus speed).
Signed-off-by: Ben Dooks <ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>
---
Index: b/drivers/spi/spi_s3c24xx.c
===================================================================
--- a/drivers/spi/spi_s3c24xx.c 2009-07-27 18:55:16.000000000 +0100
+++ b/drivers/spi/spi_s3c24xx.c 2009-07-27 18:56:08.000000000 +0100
@@ -116,6 +116,12 @@ static int s3c24xx_spi_setupxfer(struct
bpw = t ? t->bits_per_word : spi->bits_per_word;
hz = t ? t->speed_hz : spi->max_speed_hz;
+ if (!bpw)
+ bpw = 8;
+
+ if (!hz)
+ hz = spi->max_speed_hz;
+
if (bpw != 8) {
dev_err(&spi->dev, "invalid bits-per-word (%d)\n", bpw);
return -EINVAL;
--
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
next prev parent reply other threads:[~2009-08-13 10:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 10:06 [patch 0/7] SPI fixes for documentation and spi_s3c24xx driver Ben Dooks
2009-08-13 10:06 ` [patch 1/7] spi: fix spelling of automatically in documentation Ben Dooks
2009-08-13 10:06 ` [patch 2/7] spi_s3c24xx: fix clock rate calculation Ben Dooks
2009-08-13 10:06 ` Ben Dooks [this message]
2009-08-13 10:06 ` [patch 4/7] spi_s3c24xx: fix header includes Ben Dooks
2009-08-13 10:06 ` [patch 5/7] spi_s3c24xx: use resource_size() to get resource size Ben Dooks
2009-08-13 10:06 ` [patch 6/7] spi_s3c24xx: use dev_pm_ops Ben Dooks
2009-08-13 10:06 ` [patch 7/7] spi_s3c24xx: cache device setup data Ben Dooks
2009-08-13 21:24 ` [patch 0/7] SPI fixes for documentation and spi_s3c24xx driver Andrew Morton
2009-08-14 14:06 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813100638.583297488@fluff.org \
--to=ben-y5a6d6n0/kfqxopxs62xeg@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uv+2+P5yyue3@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).