archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <>
To: Andrew Morton <>
Subject: Re: [PATCH 0/7] Updates for spi-imx
Date: Thu, 1 Oct 2009 06:59:45 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Andrew,

On Wed, Sep 30, 2009 at 04:52:41PM -0700, Andrew Morton wrote:
> On Wed, 30 Sep 2009 21:42:11 +0200
> Uwe Kleine-K__nig <> wrote:
> > as a followup to this mail I'll send some updates for the spi-imx
> > driver for review.
> Several of these patches were unchangelogged but afaict they all fix
> bugs and hence should be in 2.6.32, yes?
I'm not sure about "strip down chipselect function to only drive the
chipselect", that's why I marked it RFC.  I see the driver working with
it and using less register writes, but if someone would check it and
consider it OK, I'd feel better. 

"spi-imx: no need to assert bits_per_word being initialized" isn't a
real bugfix, it just removes an if(...) that is never hit.

The other (non-naughty) patches are bugfixes, yes.
> Renaming the entire source file after -rc1 was probably a bit naughty,
> but we'll survive.
I didn't target for 2.6.32, I just wanted to get rid of the patches.
The earlier they get in the better for me.

To be honest I expected to get back some patches because of the missing
changelog.  I just wanted to get them out before going to bed.

Best regards and thanks for picking my patches up

Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    |  |

      reply	other threads:[~2009-10-01  4:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-30 19:42 [PATCH 0/7] Updates for spi-imx Uwe Kleine-König
     [not found] ` <>
2009-09-30 19:43   ` [PATCH 1/7] spi-imx: rename source file to spi_imx.c Uwe Kleine-König
     [not found]     ` <>
2009-09-30 19:43       ` [PATCH 2/7] spi-imx: update state correctly Uwe Kleine-König
2009-09-30 19:43         ` [PATCH 3/7] spi-imx: Fix initial chipselect settings Uwe Kleine-König
     [not found]           ` <>
2009-09-30 19:43             ` [PATCH 4/7] spi-imx: setup mode_bits we can handle Uwe Kleine-König
2009-09-30 19:43               ` [PATCH 5/7] spi-imx: no need to assert bits_per_word being initialized Uwe Kleine-König
     [not found]                 ` <>
2009-09-30 19:43                   ` [PATCH 6/7] spi-imx: initialize complete config struct Uwe Kleine-König
2009-09-30 19:43                     ` [PATCH 7/7 RFC] spi-imx: strip down chipselect function to only drive the chipselect Uwe Kleine-König
2009-09-30 23:52 ` [PATCH 0/7] Updates for spi-imx Andrew Morton
2009-10-01  4:59   ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).