From: Wolfram Sang <w.sang@pengutronix.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Kári Davíðsson" <kari.davidsson@marel.com>,
spi-devel-general@lists.sourceforge.net, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()
Date: Sat, 31 Oct 2009 10:03:56 +0100 [thread overview]
Message-ID: <20091031090356.GA4722@pengutronix.de> (raw)
In-Reply-To: <20091031163259.5c651773.sfr@canb.auug.org.au>
[-- Attachment #1.1: Type: text/plain, Size: 988 bytes --]
Hi Stephen,
> > static struct of_platform_driver mpc52xx_psc_spi_of_driver = {
> > .owner = THIS_MODULE,
> > - .name = "mpc52xx-psc-spi",
> > + .name = DRIVER_NAME,
>
> You no longer need to set either owner or name in the of_platform driver,
> just in the included struct driver (as is done below), so you could just
> remove the above two lines.
Okay, thanks. Will drop it.
>
> > .match_table = mpc52xx_psc_spi_of_match,
> > .probe = mpc52xx_psc_spi_of_probe,
> > .remove = __exit_p(mpc52xx_psc_spi_of_remove),
> > .driver = {
> > - .name = "mpc52xx-psc-spi",
> > + .name = DRIVER_NAME,
> > .owner = THIS_MODULE,
> > },
> > };
>
> I am hoping that we can remove the owner and name fields from struct
> of_platform_driver sometime.
Sounds good! :)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2009-10-31 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 19:44 [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices() Wolfram Sang
2009-10-31 5:32 ` Stephen Rothwell
2009-10-31 9:03 ` Wolfram Sang [this message]
2009-11-01 1:03 ` Grant Likely
2009-11-02 13:14 ` Wolfram Sang
2009-11-02 16:08 ` Grant Likely
[not found] ` <fa686aa40911020808n73a898ack5fb66933188555da-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-03 11:43 ` [PATCH] mpc52xx-psc-spi: Enumerate child nodes in the OF tree Kári Davíðsson
[not found] ` <4AF01751.1090806-zCUwNCi8n9MAvxtiuMwx3w@public.gmane.org>
2009-11-03 13:05 ` Wolfram Sang
[not found] ` <20091103130515.GS3571-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-11-03 13:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091031090356.GA4722@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=kari.davidsson@marel.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).