From: Anton Vorontsov <firstname.lastname@example.org>
To: Grant Likely <email@example.com>
Cc: Torsten Fleischer <firstname.lastname@example.org>,
Subject: Re: spi_mpc8xxx.c: chip select polarity problem
Date: Thu, 26 Nov 2009 15:12:04 +0300 [thread overview]
Message-ID: <20091126121204.GA3558@oksana.dev.rtsoft.ru> (raw)
On Wed, Nov 25, 2009 at 03:11:57PM -0700, Grant Likely wrote:
> On Wed, Nov 25, 2009 at 1:41 PM, Torsten Fleischer
> <email@example.com> wrote:
> > On Wen, Nov 25, 2009 at 01:33:57 Grant Likely wrote:
> >> Thanks. However, there needs to be a proper description of what this
> >> patch does to go in the commit header. Can you please write one?
> >> Thanks,
> >> g.
> > [...]
> > The initialization of the chip selects is removed from the probe() function of
> > the spi_mpc8xxx driver, because the driver doesn't know the polarity of the
> > chip selects of the SPI devices at the time of its initialization.
> > For this reason the initialization of the several chip selects is postponed
> > to the point of time when the very first SPI transfer to the associated device
> > occurs.
> > Signed-off-by: Torsten Fleischer <firstname.lastname@example.org>
> Ah. I understand what you're doing now. Hmmm. This approach
> concerns me because it relies on firmware or platform code to get CS
> gpios set up properly before the driver is probed.
Yes, that was said at the very beginning of this thread.
> Firmware doesn't
> always get it right, and I prefer to avoid platform specific setups as
> much as possible. Why can't the CS polarity be encoded into the
> device tree so the driver *does* have the polarity data at probe time?
We have the spi-cs-high property, but it duplicates compatible
property. 'compatible' is enough to tell whether some device has
cs-high or cs-low (device's driver knows that already).
The problem is that SPI bus master doesn't know all the devices,
so it can't extract that information from the compatible string.
To workaround that we can use 'spi-cs-high', but that's ugly
SPI modes (0,1,2,3) is another matter, some devices can work in
several modes, so 'spi-cpol' and 'spi-cpha' are actually useful.
Linuxppc-dev mailing list
next prev parent reply other threads:[~2009-11-26 12:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <email@example.com>
[not found] ` <firstname.lastname@example.org>
[not found] ` <email@example.com>
[not found] ` <firstname.lastname@example.org>
2009-11-25 22:11 ` spi_mpc8xxx.c: chip select polarity problem Grant Likely
2009-11-26 12:12 ` Anton Vorontsov [this message]
2009-11-26 17:27 ` Torsten Fleischer
2009-11-26 18:18 ` Grant Likely
2009-11-26 18:16 ` Grant Likely
2009-11-26 18:41 ` Anton Vorontsov
2009-11-26 18:50 ` Grant Likely
2009-11-26 19:01 ` Anton Vorontsov
2009-11-26 19:17 ` Grant Likely
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).