From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: spi_mpc8xxx.c: chip select polarity problem Date: Thu, 26 Nov 2009 21:41:57 +0300 Message-ID: <20091126184157.GA16607@oksana.dev.rtsoft.ru> References: <200911161742.46663.to-fleischer@t-online.de> <200911211708.47253.to-fleischer@t-online.de> <200911252141.59549.to-fleischer@t-online.de> <20091126121204.GA3558@oksana.dev.rtsoft.ru> Reply-To: avorontsov@ru.mvista.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Torsten Fleischer , spi-devel-general@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org To: Grant Likely Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org List-Id: linux-spi.vger.kernel.org On Thu, Nov 26, 2009 at 11:16:34AM -0700, Grant Likely wrote: [...] > The spi-cs-high property is defined in > Documentation/powerpc/dts-bindings/spi-bus.txt, but it definitely was > a mistake Yup. > Currently the spi-cs-high property is parsed in the > of_register_spi_devices() function, but the CS polarity needs to be > known before registering devices. It needs to be factored out into > another utility function callable by spi bus drivers so that it can > get polarity data at probe time. Untill we have this, Torsten's patch is a real improvement, and works for non-broken hw/fw. So I think it should be applied. Thanks, -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2