From: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
To: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: David Brownell
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>,
"linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
spi-devel-list
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org"
<alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Subject: Re: [RFC][PATCH v2] serial: spi: add spi-uart driver for Maxim 3110
Date: Wed, 17 Feb 2010 14:58:17 -0800 [thread overview]
Message-ID: <20100217225817.GD31557@kroah.com> (raw)
In-Reply-To: <20100209093644.2dead2d9@feng-i7>
On Tue, Feb 09, 2010 at 09:36:44AM +0800, Feng Tang wrote:
> On Tue, 9 Feb 2010 08:26:35 +0800
> Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
>
> > On Mon, Feb 8, 2010 at 5:20 PM, Andrew Morton
> > <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
> > > On Mon, 8 Feb 2010 16:59:46 +0800
> > > Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> > >
> > >> Hi All,
> > >>
> > >> Here is a driver for Maxim 3110 SPI-UART device, please help to
> > >> review.
> > >>
> > >> It has been validated with Designware SPI controller (drivers/spi:
> > >> dw_spi.c & dw_spi_pci.c). It supports polling and IRQ mode,
> > >> supports batch read, and provides a console.
> > >>
>
> > > I wonder if this is an "spi" subsystem thing or a "serial" subsystem
> > > thing. It looks more like a serial driver to me.
> >
> > I'm assuming serial; and hence I haven't picked it up into my tree.
> >
> > g.
>
> Yes, it's more related to serial stuff, and thus I put them into
> drivers/serial
That's fine. Care to address Andrew's issues and resend the patch?
thanks,
greg k-h
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
next prev parent reply other threads:[~2010-02-17 22:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091229222006.1ddb28a4@feng-desktop>
2009-12-29 14:59 ` [spi-devel-general] [RFC][PATCH] serial: spi: add spi-uart driver for Maxim 3110 Baruch Siach
2009-12-29 16:05 ` Tang, Feng
2009-12-29 18:43 ` Erwin Authried
2009-12-30 1:54 ` Feng Tang
2010-02-25 4:47 ` David Brownell
2010-02-25 7:49 ` Feng Tang
2009-12-29 15:02 ` Alan Cox
2010-02-08 8:59 ` [RFC][PATCH v2] " Feng Tang
[not found] ` <20100208165946.0e4dde83@feng-i7>
2010-02-09 0:20 ` Andrew Morton
2010-02-09 0:26 ` Grant Likely
2010-02-09 1:36 ` Feng Tang
2010-02-17 22:58 ` Greg KH [this message]
2010-02-24 5:11 ` [RFC][PATCH v3] " Feng Tang
2010-02-24 10:44 ` Alan Cox
2010-02-24 14:25 ` Grant Likely
2010-02-24 23:18 ` Andrew Morton
2010-02-25 6:39 ` Feng Tang
2010-02-25 4:43 ` David Brownell
2010-02-25 7:44 ` Feng Tang
2010-02-25 8:11 ` David Brownell
2010-02-26 3:47 ` [PATCH v4] " Feng Tang
[not found] ` <20100226114729.679bb933@feng-i7>
2010-02-26 9:59 ` Masakazu Mokuno
2010-02-26 19:41 ` David Brownell
2010-03-01 2:30 ` Feng Tang
2010-03-02 3:38 ` Feng Tang
2010-02-09 9:25 ` [RFC][PATCH v2] " Alan Cox
2010-03-03 2:57 ` [PATCH v5] " Feng Tang
2010-03-03 3:59 ` Grant Likely
2010-03-03 4:51 ` David Brownell
2010-03-03 5:52 ` Feng Tang
2010-03-03 6:16 ` David Brownell
2010-03-03 6:37 ` Feng Tang
2010-03-03 7:25 ` David Brownell
2010-03-03 7:42 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217225817.GD31557@kroah.com \
--to=greg-u8xffu+wg4eavxtiumwx3w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).