From mboxrd@z Thu Jan  1 00:00:00 1970
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [sodaville] [PATCH 1/9] spi/pxa2xx: don't use subys initcall
	for driver init
Date: Fri, 26 Nov 2010 11:06:05 +0000
Message-ID: <20101126110605.GI9310@n2100.arm.linux.org.uk>
References: <1290597207-29838-1-git-send-email-bigeasy@linutronix.de>
	<1290597207-29838-2-git-send-email-bigeasy@linutronix.de>
	<AANLkTin4vh85XRkEd7YocCmKngViR_qZDe7z1b4JXyd-@mail.gmail.com>
	<4CED1C95.8070300@linutronix.de>
	<20101124141623.GH24970@rakim.wolfsonmicro.main>
	<4CED3199.2040700@linutronix.de>
	<20101125235415.GA9310@n2100.arm.linux.org.uk>
	<20101126105028.GA24010@www.tglx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: David Brownell <dbrownell@users.sourceforge.net>, eric.y.miao@gmail.com,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	sodaville@linutronix.de, drwyrm@gmail.com,
	spi-devel-general@lists.sourceforge.net,
	linux-arm-kernel@lists.infradead.org
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Return-path: <linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org>
Content-Disposition: inline
In-Reply-To: <20101126105028.GA24010@www.tglx.de>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>,
	<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
	<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Sender: linux-arm-kernel-bounces@lists.infradead.org
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org
List-Id: linux-spi.vger.kernel.org

On Fri, Nov 26, 2010 at 11:50:28AM +0100, Sebastian Andrzej Siewior wrote:
> * Russell King - ARM Linux | 2010-11-25 23:54:15 [+0000]:
> 
> >Why should the PXA code change when you haven't explained _why_ you want
> >to change the SPI driver to conform to your idea?
> 
> The problem was, that the platform driver never got probed after I
> registered the PCI driver. For that reason I made the patch attached. It
> got lost while moving the tree forward and I did not notice it earlier.
> While at it, I changed the subsys_init to module_init because it looked
> wrong. At this time I was also thinking about using one module for the
> platform and PCI code but never got to it.

This is one of the problems of the foo_driver_probe() idea - if the
device is not present at the time the driver is registered, then the
driver loses out completely.

This would seem to be exagerated as you're creating this platform device
from a PCI device - who's to say that someone won't unbind the PCI device
and re-bind it later, causing the platform device to be deleted and
re-created?

As such, I think the patch you've shown in this email is more appropriate
(getting rid of the platform_driver_probe()) than trying to sort out
init-level dependencies.  Really, the init-level dependencies in this case
are not the problem - the use of platform_driver_probe() is.