From: Wolfram Sang <w.sang@pengutronix.de>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: spi-devel-general@lists.sourceforge.net,
Grant Likely <grant.likely@secretlab.ca>,
David Brownell <dbrownell@users.sourceforge.net>,
linux-kernel@vger.kernel.org, Michael Buesch <mb@bu3sch.de>
Subject: Re: [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from cs during transfer
Date: Fri, 10 Dec 2010 12:46:04 +0100 [thread overview]
Message-ID: <20101210114604.GB4228@pengutronix.de> (raw)
In-Reply-To: <67270e44ec792d1a684d6052f7aebbc8c538a6c1.1291925752.git.bengardiner@nanometrics.ca>
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
Hi,
thanks for the submission. It has some issues, though:
On Thu, Dec 09, 2010 at 03:34:55PM -0500, Ben Gardiner wrote:
> + nsecs =
> +#if defined(CONFIG_SLOWER_SPI_GPIO)
> + !cs->nsecs ? cs->nsecs : 100;
> +#else
> + 100;
> +#endif
This coding style is very hard to read and gains nothing for it. Also,
slower_spi should rather be a per-device than a config option.
Kind regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-12-10 11:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 22:19 [PATCH][RFC] spi-gpio: implement spidelay() for platforms that configure SLOWER_SPI_GPIO Ben Gardiner
2010-12-09 20:34 ` [RFC][PATCH v2 0/3] slower spi-gpio Ben Gardiner
2010-12-09 20:34 ` [RFC][PATCH v2 1/3] spi-gpio: implement spidelay() for platforms that configure SLOWER_SPI_GPIO Ben Gardiner
2010-12-09 20:34 ` [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from cs during transfer Ben Gardiner
2010-12-10 11:46 ` Wolfram Sang [this message]
2010-12-14 16:58 ` Ben Gardiner
2010-12-14 18:08 ` Wolfram Sang
2010-12-14 18:17 ` Ben Gardiner
2010-12-09 20:34 ` [RFC][PATCH v2 3/3] spi-gpio: use _cansleep when CONFIG_SLOWER_SPI_GPIO is defined Ben Gardiner
2010-12-10 4:38 ` [RFC][PATCH v2 0/3] slower spi-gpio David Brownell
2010-12-14 16:58 ` Ben Gardiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210114604.GB4228@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=bengardiner@nanometrics.ca \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).