From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andres Salomon <dilinger@queued.net>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Grant Likely <grant.likely@secretlab.ca>,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: [PATCH] spi/spi_oc_tiny and spi_altera.c: fix build errors
Date: Tue, 22 Feb 2011 13:35:29 -0800 [thread overview]
Message-ID: <20110222133529.56b02ebb.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20110222132438.02d310e0@queued.net>
On Tue, 22 Feb 2011 13:24:38 -0800 Andres Salomon wrote:
> Fix the following build error due to a missing semicolon:
>
> CC [M] drivers/spi/spi_oc_tiny.o
> drivers/spi/spi_oc_tiny.c:394: error: expected ‘,’ or ‘;’ before ‘extern’
> make[2]: *** [drivers/spi/spi_oc_tiny.o] Error 1
>
> Signed-off-by: Andres Salomon <dilinger@queued.net>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Same fix is needed for drivers/spi/spi_altera.c.
I already had this patch ready to send. Grant, can you extract
the spi_altera.c patch...?
---
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix build error due to missing semi-colon:
drivers/spi/spi_altera.c:308: error: expected ',' or ';' before 'extern'
drivers/spi/spi_oc_tiny.c:394: error: expected ',' or ';' before 'extern'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/spi/spi_altera.c | 2 +-
drivers/spi/spi_oc_tiny.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20110222.orig/drivers/spi/spi_oc_tiny.c
+++ linux-next-20110222/drivers/spi/spi_oc_tiny.c
@@ -390,7 +390,7 @@ static int __devexit tiny_spi_remove(str
static const struct of_device_id tiny_spi_match[] = {
{ .compatible = "opencores,tiny-spi-rtlsvn2", },
{},
-}
+};
MODULE_DEVICE_TABLE(of, tiny_spi_match);
#else /* CONFIG_OF */
#define tiny_spi_match NULL
--- linux-next-20110222.orig/drivers/spi/spi_altera.c
+++ linux-next-20110222/drivers/spi/spi_altera.c
@@ -304,7 +304,7 @@ static int __devexit altera_spi_remove(s
static const struct of_device_id altera_spi_match[] = {
{ .compatible = "ALTR,spi-1.0", },
{},
-}
+};
MODULE_DEVICE_TABLE(of, altera_spi_match);
#else /* CONFIG_OF */
#define altera_spi_match NULL
next prev parent reply other threads:[~2011-02-22 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 21:24 [PATCH] spi/spi_oc_tiny: fix build error Andres Salomon
2011-02-22 21:35 ` Randy Dunlap [this message]
2011-02-22 22:02 ` [PATCH] spi/spi_oc_tiny and spi_altera.c: fix build errors Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222133529.56b02ebb.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=dbrownell@users.sourceforge.net \
--cc=dilinger@queued.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).