From: Grant Likely <grant.likely@secretlab.ca>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Harini Jayaraman <harinij@codeaurora.org>,
bryanh@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, kheitke@codeaurora.org,
spi-devel-general@lists.sourceforge.net, davidb@codeaurora.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] spi: QUP based bus driver for Qualcomm MSM chipsets
Date: Mon, 23 Jan 2012 05:56:26 -0700 [thread overview]
Message-ID: <20120123125626.GA23571@ponder.secretlab.ca> (raw)
In-Reply-To: <20111207223757.GE3744@pengutronix.de>
On Wed, Dec 07, 2011 at 11:37:58PM +0100, Wolfram Sang wrote:
> On Mon, Nov 14, 2011 at 02:58:27PM -0700, Harini Jayaraman wrote:
> > This bus driver supports the QUP SPI hardware controller in the Qualcomm
> > MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general
> > purpose data path engine with input/output FIFOs and an embedded SPI
> > mini-core. The driver currently supports only FIFO mode.
> >
> > Signed-off-by: Harini Jayaraman <harinij@codeaurora.org>
>
> Wow, this driver is huge. This is a rough review only, mainly to see
> what can go away. This will make further reviews easier.
>
> > ---
> > v2: Updated copyright information (addresses comments from Bryan Huntsman).
> > Files renamed.
> > ---
> > drivers/spi/Kconfig | 10 +
> > drivers/spi/Makefile | 1 +
> > drivers/spi/spi-qup.c | 1144 +++++++++++++++++++++++++++++++++
> > drivers/spi/spi-qup.h | 436 +++++++++++++
> > include/linux/platform_data/msm_spi.h | 19 +
> > 5 files changed, 1610 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/spi/spi-qup.c
> > create mode 100644 drivers/spi/spi-qup.h
Why the separate header file? From what I can tell, only spi-qup.c
uses it, so the definitions should be directly in spi-qup.c.
g.
next prev parent reply other threads:[~2012-01-23 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 21:58 [PATCH v2] spi: QUP based bus driver for Qualcomm MSM chipsets Harini Jayaraman
2011-12-07 22:37 ` Wolfram Sang
2011-12-12 22:28 ` Harini Jayaraman
2011-12-12 22:36 ` David Brown
2012-01-23 12:56 ` Grant Likely [this message]
2012-01-23 10:42 ` Russell King - ARM Linux
2012-01-23 15:58 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123125626.GA23571@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=harinij@codeaurora.org \
--cc=kheitke@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).