From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [06/10,V2] spi: Add SPI driver for mx233/mx28 Date: Wed, 1 Aug 2012 12:50:12 +0800 Message-ID: <20120801045010.GC1672@S2100-06.ap.freescale.net> References: <1341555449-17507-6-git-send-email-marex@denx.de> <20120731205300.GA25721@roeck-us.net> <201208010431.04399.marex@denx.de> <20120801035333.GB1672@S2100-06.ap.freescale.net> <20120801033559.GB2323@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Marek Vasut , Estevam , Fabio, Wolfgang Denk , Zundel , Detlev, Rob Herring , Stefano Babic , Dong, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Chris Ball , Aisheng , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Guenter Roeck Return-path: Content-Disposition: inline In-Reply-To: <20120801033559.GB2323-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote: > I think the call to spi_master_put() triggers the call to spi_master_release(). > If so, kfree() would not be needed at all, and the documentation is wrong. > Also those drivers calling kfree in probe. Regards, Shawn ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/