From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [06/10,V2] spi: Add SPI driver for mx233/mx28 Date: Wed, 1 Aug 2012 07:00:54 +0200 Message-ID: <201208010700.54829.marex@denx.de> References: <1341555449-17507-6-git-send-email-marex@denx.de> <20120801033559.GB2323@roeck-us.net> <20120801045010.GC1672@S2100-06.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Fabio Estevam , Stefano Babic , Guenter Roeck , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Chris Ball , Dong Aisheng , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shawn Guo , Rob Herring Return-path: In-Reply-To: <20120801045010.GC1672-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Dear Shawn Guo, > On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote: > > I think the call to spi_master_put() triggers the call to > > spi_master_release(). If so, kfree() would not be needed at all, and the > > documentation is wrong. > > Also those drivers calling kfree in probe. Looks like that to me ... > Regards, > Shawn Best regards, Marek Vasut ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/