On Fri, Feb 15, 2013 at 04:52:25PM +0100, Andreas Larsson wrote: > Acked-by: Anton Vorontsov > Signed-off-by: Andreas Larsson I'll apply this on account of it being part of the series and review having been very slow but... > /* Make sure its a bit width we support [4..16, 32] */ > if ((bits_per_word < 4) > - || ((bits_per_word > 16) && (bits_per_word != 32))) > + || ((bits_per_word > 16) && (bits_per_word != 32)) > + || (bits_per_word > mpc8xxx_spi->max_bits_per_word)) > return -EINVAL; ...we do have support for this in the core now, it would be good to convert over to that.