From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: Fwd: [alsa-devel] [PATCH 1/1] SPI : spi-pxa2xx : fix spi init of WM510205 codec via ACPI (resend) Date: Thu, 25 Jun 2015 17:11:08 +0100 Message-ID: <20150625161108.GF6321@opensource.wolfsonmicro.com> References: <20150625073618.GH827@lahna.fi.intel.com> <20150625145853.GP14071@sirena.org.uk> <20150625154407.GE6321@opensource.wolfsonmicro.com> <20150625155612.GS14071@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christian Hartmann , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Robert Jarzmik , Daniel Mack , Haojian Zhuang , jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org To: Mark Brown Return-path: Content-Disposition: inline In-Reply-To: <20150625155612.GS14071-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Thu, Jun 25, 2015 at 04:56:12PM +0100, Mark Brown wrote: > On Thu, Jun 25, 2015 at 04:44:07PM +0100, Charles Keepax wrote: > > On Thu, Jun 25, 2015 at 03:58:53PM +0100, Mark Brown wrote: > > > On Thu, Jun 25, 2015 at 02:18:23PM +0200, Christian Hartmann wrote: > > > > > Name (_HID, "WM510205") // _HID: Hardware ID > > > > Name (_CID, "WM510205") // _CID: Compatible ID > > > > Name (_DDN, "Wolfson Microelectronics Audio WM5102") > > > > Separately to the chip select discussion one thing to highlight here is > > > that for some reason the BIOS is listing the device as "WM510205" rather > > > than "WM5102" - do those extra numbers mean anything and does this mean > > > that WM50120[1-4] and possibly higher numbers are also valid? > > > From my brief discussions with the Windows guys here on this > > basically those last two digits are being used to inform the > > Windows driver of use-case setup. So here it will set things up > > for whatever the Window's driver considers to be setup "5". > > Yay for scalability and abstraction. Well it certainly is abstract. > > > I think from the Linux side we can safely ignore those last two > > digits. I expect that all systems of the same make and model > > would report the same last two digits but that it might change > > between models if the Windows driver is expected to something > > differently for that model. > > Well, we might want to consider using this to set our platform data > instead of the machine ID if people have just been copying a smallish > set of reference designs, it might might make for a slightly smaller set > of ID tables than the machine ID based stuff does. > > Due to the way ACPI ID matching works we'll also need to add every > suffix individually to the table, we're looking for complete matches not > substring matches here. >>From what I can gather currently yes every system has a different suffix so it should be fine to skip checking the machine ID and just use the ACPI ID to select the pdata. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html