From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jiri Prchal <jiri.prchal-cKCO0sOKHLPtwjQa/ONI9g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] misc: eeprom: at25: add Cypress FRAM functionality
Date: Tue, 6 Oct 2015 15:40:48 +0100 [thread overview]
Message-ID: <20151006144048.GS12635@sirena.org.uk> (raw)
In-Reply-To: <c7beacd629a47a0bd5023353378a3eda4d7d0f89.1444139729.git.jiri.prchal-cKCO0sOKHLPtwjQa/ONI9g@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On Tue, Oct 06, 2015 at 04:01:32PM +0200, Jiri Prchal wrote:
> This patch adds functionality for Cypress FRAMs on SPI bus, such as FM25V05,
> FM25V10 etc.
I'm not entirely sure why I got CCed on this?
> + mutex_lock(&at25->lock);
> +
> + status = spi_sync(at25->spi, &m);
> + dev_dbg(&at25->spi->dev,
> + "read %Zd bytes of ID --> %d\n",
> + FM25_ID_LEN, (int) status);
> +
> + mutex_unlock(&at25->lock);
There is no point in holding a lock around spi_sync(), the SPI framework
has locking which will ensure spi_sync() and spi_async() calls will be
serialised.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-06 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 14:01 [PATCH] misc: eeprom: at25: add Cypress FRAM functionality Jiri Prchal
[not found] ` <c7beacd629a47a0bd5023353378a3eda4d7d0f89.1444139729.git.jiri.prchal-cKCO0sOKHLPtwjQa/ONI9g@public.gmane.org>
2015-10-06 14:40 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-21 10:37 Jiri Prchal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006144048.GS12635@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=jiri.prchal-cKCO0sOKHLPtwjQa/ONI9g@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).