linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Gao Pan <pandy.gao-3arQi8VN3Tc@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	frank.li-3arQi8VN3Tc@public.gmane.org,
	fugang.duan-3arQi8VN3Tc@public.gmane.org
Subject: Re: [Patch v1 1/2] spi: imx: add lpspi bus driver
Date: Mon, 14 Nov 2016 12:09:42 +0000	[thread overview]
Message-ID: <20161114120942.uzswqewdyh3xgfse@sirena.org.uk> (raw)
In-Reply-To: <1479100967-1894-1-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

On Mon, Nov 14, 2016 at 01:22:46PM +0800, Gao Pan wrote:

> +config SPI_FSL_LPSPI
> +	tristate "Freescale i.MX LPSPI controller"
> +	depends on ARCH_MXC || COMPILE_TEST
> +	select SPI_BITBANG

Don't use SPI_BITBANG for anything that isn't actually bitbanging (which
this clearly isn't).  Use the normal SPI interfaces, all the queue
handling that people used to abuse SPI_BITBANG for is now in the core.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  parent reply	other threads:[~2016-11-14 12:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14  5:22 [Patch v1 1/2] spi: imx: add lpspi bus driver Gao Pan
     [not found] ` <1479100967-1894-1-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org>
2016-11-14  5:22   ` [Patch v1 2/2] spi: imx: add devicetree binding for lpspi Gao Pan
     [not found]     ` <1479100967-1894-2-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org>
2016-11-23 12:38       ` Applied "spi: imx: add devicetree binding for lpspi" to the spi tree Mark Brown
2016-11-14 12:09   ` Mark Brown [this message]
     [not found]     ` <20161114120942.uzswqewdyh3xgfse-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-11-15 13:29       ` [Patch v1 1/2] spi: imx: add lpspi bus driver Pandy Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161114120942.uzswqewdyh3xgfse@sirena.org.uk \
    --to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=frank.li-3arQi8VN3Tc@public.gmane.org \
    --cc=fugang.duan-3arQi8VN3Tc@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pandy.gao-3arQi8VN3Tc@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).